-
-
Notifications
You must be signed in to change notification settings - Fork 356
Comparing changes
Open a pull request
base repository: symfony/ux
base: v2.18.0
head repository: symfony/ux
compare: v2.18.1
- 12 commits
- 9 files changed
- 5 contributors
Commits on Jun 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d3bba1 - Browse repository at this point
Copy the full SHA 5d3bba1View commit details -
minor #1898 [Icons] Update composer (smnandre)
This PR was merged into the 2.x branch. Discussion ---------- [Icons] Update composer 🤝 `@kbond` Commits ------- 5d3bba1 [Icons] Update composer
Configuration menu - View commit details
-
Copy full SHA for 7a84975 - Browse repository at this point
Copy the full SHA 7a84975View commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 044f338 - Browse repository at this point
Copy the full SHA 044f338View commit details -
Configuration menu - View commit details
-
Copy full SHA for a27cfc8 - Browse repository at this point
Copy the full SHA a27cfc8View commit details
Commits on Jun 11, 2024
-
[Fix] Revert removing
twig_component.controllers_json
I removed this key because it was an mistake (never used, documented, or written in recipes) I wrongly did not consider this a BC, and it was. So this PR re-adds the configuration key and deprecates it instead. Should this be acceptable in a hotfix version like 2.18.1 ?
Configuration menu - View commit details
-
Copy full SHA for 6c397d5 - Browse repository at this point
Copy the full SHA 6c397d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4867dd1 - Browse repository at this point
Copy the full SHA 4867dd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf5959f - Browse repository at this point
Copy the full SHA bf5959fView commit details -
bug #1911 [TwigComponent][Fix] Revert throwing exception when public …
…property is unitialized (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent][Fix] Revert throwing exception when public property is unitialized | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | Fix #1909 | License | MIT Revert #1780 If someone want to give another go at the original problem i'd appreciate. Commits ------- bf5959f [Fix] Revert throwing exception when public property is unitialized
Configuration menu - View commit details
-
Copy full SHA for bb903c2 - Browse repository at this point
Copy the full SHA bb903c2View commit details -
minor #1910 [Docs][Stimulus] use camelCase for target naming (Jibbarth)
This PR was merged into the 2.x branch. Discussion ---------- [Docs][Stimulus] use camelCase for target naming | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Hello! I had some trouble following the doc for use `stimulus_target` and how to use them inside my stimulus controller. As we can see [on the stimulus target doc](https://stimulus.hotwired.dev/reference/targets#naming-conventions), the value of target should be in camelCase as it's mapped in property in the controller. IE ``` <div data-my-controller-target="myElement"> ``` ``` import { Controller } from "`@hotwired`/stimulus" export default class extends Controller { static targets = [ "myElement"] // … foo() { this.myElementTarget.innerHTML = "..."; } } ``` So in this PR, I changed examples for `stimulus_target` usage. Commits ------- 4867dd1 [Docs][Stimulus] use camelCase for target naming
Configuration menu - View commit details
-
Copy full SHA for 5099e8b - Browse repository at this point
Copy the full SHA 5099e8bView commit details -
bug #1908 [Fix] Revert removing
twig_component.controllers_json
(sm……nandre) This PR was merged into the 2.x branch. Discussion ---------- [Fix] Revert removing `twig_component.controllers_json` | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | Fix # | License | MIT I [removed](https://github.com/symfony/ux/pull/1823/files) this key because it was an [mistake](0284c0a) (never used, documented, or written in recipes) I wrongly did not consider this a BC break, and it was. This PR re-adds the configuration key and deprecates it instead. -- Should this be acceptable in a hotfix version like 2.18.1 ? Commits ------- 6c397d5 [Fix] Revert removing `twig_component.controllers_json`
Configuration menu - View commit details
-
Copy full SHA for 4ca6f2f - Browse repository at this point
Copy the full SHA 4ca6f2fView commit details -
bug #1904 [Translator] Fix changing dump directory using AssetMapper …
…(maelanleborgne) This PR was merged into the 2.x branch. Discussion ---------- [Translator] Fix changing dump directory using AssetMapper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | Fix #1642 | License | MIT The configuration node `ux_translator.dump_directory` wasn't correctly taken into account when using UxTranslator with AssetMapper. This PR fixes the configuration prepend of AssetMapper to use the custom path + adds a "caution" section in the docs to remind developers to also update their `importmap.php`. Commits ------- a27cfc8 Fix changing dump directory using AssetMapper
Configuration menu - View commit details
-
Copy full SHA for fc8de45 - Browse repository at this point
Copy the full SHA fc8de45View commit details -
bug #1903 [LiveComponent] accept live component Content-Type with suf…
…fix (WebMamba) This PR was merged into the 2.x branch. Discussion ---------- [LiveComponent] accept live component Content-Type with suffix | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | Fix #1902 | License | MIT Commits ------- 044f338 [LiveComponent] accept live component Content-Type with suffix
Configuration menu - View commit details
-
Copy full SHA for 3b65275 - Browse repository at this point
Copy the full SHA 3b65275View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.18.0...v2.18.1