Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/ux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.18.0
Choose a base ref
...
head repository: symfony/ux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.18.1
Choose a head ref
  • 12 commits
  • 9 files changed
  • 5 contributors

Commits on Jun 7, 2024

  1. [Icons] Update composer

    smnandre committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5d3bba1 View commit details
    Browse the repository at this point in the history
  2. minor #1898 [Icons] Update composer (smnandre)

    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [Icons] Update composer
    
    🤝  `@kbond`
    
    Commits
    -------
    
    5d3bba1 [Icons] Update composer
    kbond committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7a84975 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    044f338 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a27cfc8 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. [Fix] Revert removing twig_component.controllers_json

    I removed this key because it was an mistake (never used, documented, or written in recipes)
    
    I wrongly did not consider this a BC, and it was.
    
    So this PR re-adds the configuration key and deprecates it instead.
    
    Should this be acceptable in a hotfix version like 2.18.1 ?
    smnandre committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6c397d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4867dd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf5959f View commit details
    Browse the repository at this point in the history
  4. bug #1911 [TwigComponent][Fix] Revert throwing exception when public …

    …property is unitialized (smnandre)
    
    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [TwigComponent][Fix] Revert throwing exception when public property is unitialized
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | Issues        | Fix #1909
    | License       | MIT
    
    Revert #1780
    
    If someone want to give another go at the original problem i'd appreciate.
    
    Commits
    -------
    
    bf5959f [Fix] Revert throwing exception when public property is unitialized
    kbond committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bb903c2 View commit details
    Browse the repository at this point in the history
  5. minor #1910 [Docs][Stimulus] use camelCase for target naming (Jibbarth)

    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [Docs][Stimulus] use camelCase for target naming
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    
    Hello!
    
    I had some trouble following the doc for use `stimulus_target` and how to use them inside my stimulus controller.
    
    As we can see [on the stimulus target doc](https://stimulus.hotwired.dev/reference/targets#naming-conventions), the value of target should be in camelCase as it's mapped in property in the controller.
    
    IE
    ```
    <div data-my-controller-target="myElement">
    ```
    
    ```
    import { Controller } from "`@hotwired`/stimulus"
    
    export default class extends Controller {
      static targets = [ "myElement"]
      // …
      foo() {
    	this.myElementTarget.innerHTML = "...";
      }
    }
    ```
    
    So in this PR, I changed examples for `stimulus_target` usage.
    
    Commits
    -------
    
    4867dd1 [Docs][Stimulus] use camelCase for target naming
    kbond committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5099e8b View commit details
    Browse the repository at this point in the history
  6. bug #1908 [Fix] Revert removing twig_component.controllers_json (sm…

    …nandre)
    
    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [Fix] Revert removing `twig_component.controllers_json`
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Issues        | Fix #
    | License       | MIT
    
    I [removed](https://github.com/symfony/ux/pull/1823/files) this key because it was an [mistake](0284c0a) (never used, documented, or written in recipes)
    
    I wrongly did not consider this a BC break, and it was.
    
    This PR re-adds the configuration key and deprecates it instead.
    
    --
    
    Should this be acceptable in a hotfix version like 2.18.1 ?
    
    Commits
    -------
    
    6c397d5 [Fix] Revert removing `twig_component.controllers_json`
    kbond committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4ca6f2f View commit details
    Browse the repository at this point in the history
  7. bug #1904 [Translator] Fix changing dump directory using AssetMapper …

    …(maelanleborgne)
    
    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [Translator] Fix changing dump directory using AssetMapper
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Issues        | Fix #1642
    | License       | MIT
    
    The configuration node `ux_translator.dump_directory` wasn't correctly taken into account when using UxTranslator with AssetMapper.
    This PR fixes the configuration prepend of AssetMapper to use the custom path + adds a "caution" section in the docs to remind developers to also update their `importmap.php`.
    
    Commits
    -------
    
    a27cfc8 Fix changing dump directory using AssetMapper
    kbond committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    fc8de45 View commit details
    Browse the repository at this point in the history
  8. bug #1903 [LiveComponent] accept live component Content-Type with suf…

    …fix (WebMamba)
    
    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    [LiveComponent] accept live component Content-Type with suffix
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Issues        | Fix #1902
    | License       | MIT
    
    Commits
    -------
    
    044f338 [LiveComponent] accept live component Content-Type with suffix
    kbond committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3b65275 View commit details
    Browse the repository at this point in the history
Loading