Skip to content

Commit 4f5f6f6

Browse files
committed
update typos in the variable description
1 parent 4416d30 commit 4f5f6f6

File tree

23 files changed

+84
-84
lines changed

23 files changed

+84
-84
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ Then perform the following commands on the root folder:
113113

114114
| Name | Description | Type | Default | Required |
115115
|------|-------------|------|---------|:--------:|
116-
| add\_cluster\_firewall\_rules | Create GKE shadow firewall rules by creating the same firewall rules as Google-managed ones with higher priority and firewall logs enabled. | `bool` | `false` | no |
117-
| add\_shadow\_firewall\_rules | Create shadow firewall rules to match the GKE managed ingress firewall rules. | `bool` | `false` | no |
116+
| add\_cluster\_firewall\_rules | Create additional firewall rules | `bool` | `false` | no |
117+
| add\_shadow\_firewall\_rules | Create GKE shadow firewall (the same as default firewall rules with firewall logs enabled). | `bool` | `false` | no |
118118
| basic\_auth\_password | The password to be used with Basic Authentication. | `string` | `""` | no |
119119
| basic\_auth\_username | The username to be used with Basic Authentication. An empty value will disable Basic Authentication, which is the recommended configuration. | `string` | `""` | no |
120120
| cluster\_autoscaling | Cluster autoscaling configuration. See [more details](https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters#clusterautoscaling) | <pre>object({<br> enabled = bool<br> min_cpu_cores = number<br> max_cpu_cores = number<br> min_memory_gb = number<br> max_memory_gb = number<br> })</pre> | <pre>{<br> "enabled": false,<br> "max_cpu_cores": 0,<br> "max_memory_gb": 0,<br> "min_cpu_cores": 0,<br> "min_memory_gb": 0<br>}</pre> | no |
@@ -132,7 +132,7 @@ Then perform the following commands on the root folder:
132132
| enable\_shielded\_nodes | Enable Shielded Nodes features on all nodes in this cluster | `bool` | `true` | no |
133133
| enable\_vertical\_pod\_autoscaling | Vertical Pod Autoscaling automatically adjusts the resources of pods controlled by it | `bool` | `false` | no |
134134
| firewall\_inbound\_ports | List of TCP ports for admission/webhook controllers | `list(string)` | <pre>[<br> "8443",<br> "9443",<br> "15017"<br>]</pre> | no |
135-
| firewall\_priority | The firewall priority of GKE shadow firewall rules. The priority should be less than 1000, which is the priority of Google-managed GKE firewall. | `number` | `1000` | no |
135+
| firewall\_priority | Priority rule for firewall rules | `number` | `1000` | no |
136136
| gcloud\_upgrade | Whether to upgrade gcloud at runtime | `bool` | `false` | no |
137137
| grant\_registry\_access | Grants created cluster-specific service account storage.objectViewer role. | `bool` | `false` | no |
138138
| horizontal\_pod\_autoscaling | Enable horizontal pod autoscaling addon | `bool` | `true` | no |
@@ -171,7 +171,7 @@ Then perform the following commands on the root folder:
171171
| remove\_default\_node\_pool | Remove default node pool while setting up the cluster | `bool` | `false` | no |
172172
| resource\_usage\_export\_dataset\_id | The ID of a BigQuery Dataset for using BigQuery as the destination of resource usage export. | `string` | `""` | no |
173173
| service\_account | The service account to run nodes as if not overridden in `node_pools`. The create\_service\_account variable default value (true) will cause a cluster-specific service account to be created. | `string` | `""` | no |
174-
| shadow\_firewall\_rules\_priority | Priority for the shadow ingress firewall rules. | `number` | `999` | no |
174+
| shadow\_firewall\_rules\_priority | The firewall priority of GKE shadow firewall rules. The priority should be less than default firewall, which is 1000. | `number` | `999` | no |
175175
| skip\_provisioners | Flag to skip all local-exec provisioners. It breaks `stub_domains` and `upstream_nameservers` variables functionality. | `bool` | `false` | no |
176176
| stub\_domains | Map of stub domains and their resolvers to forward DNS queries for a certain domain to an external DNS server | `map(list(string))` | `{}` | no |
177177
| subnetwork | The subnetwork to host the cluster in (required) | `string` | n/a | yes |

autogen/main/firewall.tf.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ resource "google_compute_firewall" "shadow_allow_pods" {
9696
count = var.add_shadow_firewall_rules ? 1 : 0
9797

9898
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-all"
99-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow pod communication."
99+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing pod communication."
100100
project = local.network_project_id
101101
network = var.network
102102
priority = var.shadow_firewall_rules_priority
@@ -122,7 +122,7 @@ resource "google_compute_firewall" "shadow_allow_master" {
122122
count = var.add_shadow_firewall_rules ? 1 : 0
123123

124124
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-master"
125-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow master and woker nodes communication."
125+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing woker nodes communication."
126126
project = local.network_project_id
127127
network = var.network
128128
priority = var.shadow_firewall_rules_priority
@@ -145,7 +145,7 @@ resource "google_compute_firewall" "shadow_allow_nodes" {
145145
count = var.add_shadow_firewall_rules ? 1 : 0
146146

147147
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-vms"
148-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow woker nodes communication."
148+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing woker nodes communication."
149149
project = local.network_project_id
150150
network = var.network
151151
priority = var.shadow_firewall_rules_priority

autogen/main/variables.tf.tmpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -539,13 +539,13 @@ variable "enable_binary_authorization" {
539539

540540
variable "add_cluster_firewall_rules" {
541541
type = bool
542-
description = "Create GKE shadow firewall rules by creating the same firewall rules as Google-managed ones with higher priority and firewall logs enabled."
542+
description = "Create additional firewall rules"
543543
default = false
544544
}
545545

546546
variable "firewall_priority" {
547547
type = number
548-
description = "The firewall priority of GKE shadow firewall rules. The priority should be less than 1000, which is the priority of Google-managed GKE firewall."
548+
description = "Priority rule for firewall rules"
549549
default = 1000
550550
}
551551

@@ -563,13 +563,13 @@ variable "gcloud_upgrade" {
563563

564564
variable "add_shadow_firewall_rules" {
565565
type = bool
566-
description = "Create shadow firewall rules to match the GKE managed ingress firewall rules."
566+
description = "Create GKE shadow firewall (the same as default firewall rules with firewall logs enabled)."
567567
default = false
568568
}
569569

570570
variable "shadow_firewall_rules_priority" {
571571
type = number
572-
description = "Priority for the shadow ingress firewall rules."
572+
description = "The firewall priority of GKE shadow firewall rules. The priority should be less than default firewall, which is 1000."
573573
default = 999
574574
}
575575

firewall.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ resource "google_compute_firewall" "shadow_allow_pods" {
9292
count = var.add_shadow_firewall_rules ? 1 : 0
9393

9494
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-all"
95-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow pod communication."
95+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing pod communication."
9696
project = local.network_project_id
9797
network = var.network
9898
priority = var.shadow_firewall_rules_priority
@@ -118,7 +118,7 @@ resource "google_compute_firewall" "shadow_allow_master" {
118118
count = var.add_shadow_firewall_rules ? 1 : 0
119119

120120
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-master"
121-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow master and woker nodes communication."
121+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing woker nodes communication."
122122
project = local.network_project_id
123123
network = var.network
124124
priority = var.shadow_firewall_rules_priority
@@ -141,7 +141,7 @@ resource "google_compute_firewall" "shadow_allow_nodes" {
141141
count = var.add_shadow_firewall_rules ? 1 : 0
142142

143143
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-vms"
144-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow woker nodes communication."
144+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing woker nodes communication."
145145
project = local.network_project_id
146146
network = var.network
147147
priority = var.shadow_firewall_rules_priority

modules/beta-private-cluster-update-variant/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ Then perform the following commands on the root folder:
144144

145145
| Name | Description | Type | Default | Required |
146146
|------|-------------|------|---------|:--------:|
147-
| add\_cluster\_firewall\_rules | Create GKE shadow firewall rules by creating the same firewall rules as Google-managed ones with higher priority and firewall logs enabled. | `bool` | `false` | no |
148-
| add\_shadow\_firewall\_rules | Create shadow firewall rules to match the GKE managed ingress firewall rules. | `bool` | `false` | no |
147+
| add\_cluster\_firewall\_rules | Create additional firewall rules | `bool` | `false` | no |
148+
| add\_shadow\_firewall\_rules | Create GKE shadow firewall (the same as default firewall rules with firewall logs enabled). | `bool` | `false` | no |
149149
| authenticator\_security\_group | The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format [email protected] | `string` | `null` | no |
150150
| basic\_auth\_password | The password to be used with Basic Authentication. | `string` | `""` | no |
151151
| basic\_auth\_username | The username to be used with Basic Authentication. An empty value will disable Basic Authentication, which is the recommended configuration. | `string` | `""` | no |
@@ -176,7 +176,7 @@ Then perform the following commands on the root folder:
176176
| enable\_shielded\_nodes | Enable Shielded Nodes features on all nodes in this cluster | `bool` | `true` | no |
177177
| enable\_vertical\_pod\_autoscaling | Vertical Pod Autoscaling automatically adjusts the resources of pods controlled by it | `bool` | `false` | no |
178178
| firewall\_inbound\_ports | List of TCP ports for admission/webhook controllers | `list(string)` | <pre>[<br> "8443",<br> "9443",<br> "15017"<br>]</pre> | no |
179-
| firewall\_priority | The firewall priority of GKE shadow firewall rules. The priority should be less than 1000, which is the priority of Google-managed GKE firewall. | `number` | `1000` | no |
179+
| firewall\_priority | Priority rule for firewall rules | `number` | `1000` | no |
180180
| gce\_pd\_csi\_driver | (Beta) Whether this cluster should enable the Google Compute Engine Persistent Disk Container Storage Interface (CSI) Driver. | `bool` | `false` | no |
181181
| gcloud\_upgrade | Whether to upgrade gcloud at runtime | `bool` | `false` | no |
182182
| grant\_registry\_access | Grants created cluster-specific service account storage.objectViewer role. | `bool` | `false` | no |
@@ -225,7 +225,7 @@ Then perform the following commands on the root folder:
225225
| resource\_usage\_export\_dataset\_id | The ID of a BigQuery Dataset for using BigQuery as the destination of resource usage export. | `string` | `""` | no |
226226
| sandbox\_enabled | (Beta) Enable GKE Sandbox (Do not forget to set `image_type` = `COS_CONTAINERD` to use it). | `bool` | `false` | no |
227227
| service\_account | The service account to run nodes as if not overridden in `node_pools`. The create\_service\_account variable default value (true) will cause a cluster-specific service account to be created. | `string` | `""` | no |
228-
| shadow\_firewall\_rules\_priority | Priority for the shadow ingress firewall rules. | `number` | `999` | no |
228+
| shadow\_firewall\_rules\_priority | The firewall priority of GKE shadow firewall rules. The priority should be less than default firewall, which is 1000. | `number` | `999` | no |
229229
| skip\_provisioners | Flag to skip all local-exec provisioners. It breaks `stub_domains` and `upstream_nameservers` variables functionality. | `bool` | `false` | no |
230230
| stub\_domains | Map of stub domains and their resolvers to forward DNS queries for a certain domain to an external DNS server | `map(list(string))` | `{}` | no |
231231
| subnetwork | The subnetwork to host the cluster in (required) | `string` | n/a | yes |

modules/beta-private-cluster-update-variant/firewall.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ resource "google_compute_firewall" "shadow_allow_pods" {
8686
count = var.add_shadow_firewall_rules ? 1 : 0
8787

8888
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-all"
89-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow pod communication."
89+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing pod communication."
9090
project = local.network_project_id
9191
network = var.network
9292
priority = var.shadow_firewall_rules_priority
@@ -112,7 +112,7 @@ resource "google_compute_firewall" "shadow_allow_master" {
112112
count = var.add_shadow_firewall_rules ? 1 : 0
113113

114114
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-master"
115-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow master and woker nodes communication."
115+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing woker nodes communication."
116116
project = local.network_project_id
117117
network = var.network
118118
priority = var.shadow_firewall_rules_priority
@@ -135,7 +135,7 @@ resource "google_compute_firewall" "shadow_allow_nodes" {
135135
count = var.add_shadow_firewall_rules ? 1 : 0
136136

137137
name = "gke-shadow-${substr(var.name, 0, min(25, length(var.name)))}-vms"
138-
description = "Managed by terraform gke module: A shadow firewall rule to match the fireall allow woker nodes communication."
138+
description = "Managed by terraform gke module: A shadow firewall rule to match the default rule allowing woker nodes communication."
139139
project = local.network_project_id
140140
network = var.network
141141
priority = var.shadow_firewall_rules_priority

modules/beta-private-cluster-update-variant/variables.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -523,13 +523,13 @@ variable "enable_binary_authorization" {
523523

524524
variable "add_cluster_firewall_rules" {
525525
type = bool
526-
description = "Create GKE shadow firewall rules by creating the same firewall rules as Google-managed ones with higher priority and firewall logs enabled."
526+
description = "Create additional firewall rules"
527527
default = false
528528
}
529529

530530
variable "firewall_priority" {
531531
type = number
532-
description = "The firewall priority of GKE shadow firewall rules. The priority should be less than 1000, which is the priority of Google-managed GKE firewall."
532+
description = "Priority rule for firewall rules"
533533
default = 1000
534534
}
535535

@@ -547,13 +547,13 @@ variable "gcloud_upgrade" {
547547

548548
variable "add_shadow_firewall_rules" {
549549
type = bool
550-
description = "Create shadow firewall rules to match the GKE managed ingress firewall rules."
550+
description = "Create GKE shadow firewall (the same as default firewall rules with firewall logs enabled)."
551551
default = false
552552
}
553553

554554
variable "shadow_firewall_rules_priority" {
555555
type = number
556-
description = "Priority for the shadow ingress firewall rules."
556+
description = "The firewall priority of GKE shadow firewall rules. The priority should be less than default firewall, which is 1000."
557557
default = 999
558558
}
559559

modules/beta-private-cluster/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ Then perform the following commands on the root folder:
122122

123123
| Name | Description | Type | Default | Required |
124124
|------|-------------|------|---------|:--------:|
125-
| add\_cluster\_firewall\_rules | Create GKE shadow firewall rules by creating the same firewall rules as Google-managed ones with higher priority and firewall logs enabled. | `bool` | `false` | no |
126-
| add\_shadow\_firewall\_rules | Create shadow firewall rules to match the GKE managed ingress firewall rules. | `bool` | `false` | no |
125+
| add\_cluster\_firewall\_rules | Create additional firewall rules | `bool` | `false` | no |
126+
| add\_shadow\_firewall\_rules | Create GKE shadow firewall (the same as default firewall rules with firewall logs enabled). | `bool` | `false` | no |
127127
| authenticator\_security\_group | The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format [email protected] | `string` | `null` | no |
128128
| basic\_auth\_password | The password to be used with Basic Authentication. | `string` | `""` | no |
129129
| basic\_auth\_username | The username to be used with Basic Authentication. An empty value will disable Basic Authentication, which is the recommended configuration. | `string` | `""` | no |
@@ -154,7 +154,7 @@ Then perform the following commands on the root folder:
154154
| enable\_shielded\_nodes | Enable Shielded Nodes features on all nodes in this cluster | `bool` | `true` | no |
155155
| enable\_vertical\_pod\_autoscaling | Vertical Pod Autoscaling automatically adjusts the resources of pods controlled by it | `bool` | `false` | no |
156156
| firewall\_inbound\_ports | List of TCP ports for admission/webhook controllers | `list(string)` | <pre>[<br> "8443",<br> "9443",<br> "15017"<br>]</pre> | no |
157-
| firewall\_priority | The firewall priority of GKE shadow firewall rules. The priority should be less than 1000, which is the priority of Google-managed GKE firewall. | `number` | `1000` | no |
157+
| firewall\_priority | Priority rule for firewall rules | `number` | `1000` | no |
158158
| gce\_pd\_csi\_driver | (Beta) Whether this cluster should enable the Google Compute Engine Persistent Disk Container Storage Interface (CSI) Driver. | `bool` | `false` | no |
159159
| gcloud\_upgrade | Whether to upgrade gcloud at runtime | `bool` | `false` | no |
160160
| grant\_registry\_access | Grants created cluster-specific service account storage.objectViewer role. | `bool` | `false` | no |
@@ -203,7 +203,7 @@ Then perform the following commands on the root folder:
203203
| resource\_usage\_export\_dataset\_id | The ID of a BigQuery Dataset for using BigQuery as the destination of resource usage export. | `string` | `""` | no |
204204
| sandbox\_enabled | (Beta) Enable GKE Sandbox (Do not forget to set `image_type` = `COS_CONTAINERD` to use it). | `bool` | `false` | no |
205205
| service\_account | The service account to run nodes as if not overridden in `node_pools`. The create\_service\_account variable default value (true) will cause a cluster-specific service account to be created. | `string` | `""` | no |
206-
| shadow\_firewall\_rules\_priority | Priority for the shadow ingress firewall rules. | `number` | `999` | no |
206+
| shadow\_firewall\_rules\_priority | The firewall priority of GKE shadow firewall rules. The priority should be less than default firewall, which is 1000. | `number` | `999` | no |
207207
| skip\_provisioners | Flag to skip all local-exec provisioners. It breaks `stub_domains` and `upstream_nameservers` variables functionality. | `bool` | `false` | no |
208208
| stub\_domains | Map of stub domains and their resolvers to forward DNS queries for a certain domain to an external DNS server | `map(list(string))` | `{}` | no |
209209
| subnetwork | The subnetwork to host the cluster in (required) | `string` | n/a | yes |

0 commit comments

Comments
 (0)