Skip to content

feat: added fscloud profile #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jun 12, 2023
Merged

feat: added fscloud profile #19

merged 28 commits into from
Jun 12, 2023

Conversation

Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented May 11, 2023 •
edited
Loading

Description

FSCloud implementation for the Event Streams module. This PR adds an FSCloud profile and example.

Types of changes in this PR

Changes that affect the core Terraform module or submodules

  • Bug fix
  • New feature
  • Dependency update

Changes that don't affect the core Terraform module or submodules

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.

Your notes helps the merger write the commit message for the PR that is published in the release notes for the module.

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@Ak-sky Ak-sky marked this pull request as draft May 12, 2023 06:51
@ocofaigh
Copy link
Contributor

@Ak-sky We have decided to add a new variable called kms_encryption_enabled and have updated some logic around the auth policy creation.. We want to roll this out to all of the database related modules. These changes can be seen in this PR terraform-ibm-modules/terraform-ibm-icd-postgresql#186
Do you want to take on that work in this PR?

@Ak-sky
Copy link
Member Author

Ak-sky commented May 15, 2023

@Ak-sky We have decided to add a new variable called kms_encryption_enabled and have updated some logic around the auth policy creation.. We want to roll this out to all of the database related modules. These changes can be seen in this PR terraform-ibm-modules/terraform-ibm-icd-postgresql#186 Do you want to take on that work in this PR?

Sure @ocofaigh, I will incorporate the changes.

@Ak-sky Ak-sky marked this pull request as ready for review May 16, 2023 06:51
@Ak-sky Ak-sky changed the title [DO NOT MERGE]feat: added fscloud profile [DO NOT MERGE] feat: added fscloud profile May 16, 2023
@Ak-sky Ak-sky marked this pull request as draft May 16, 2023 06:51
@ocofaigh
Copy link
Contributor

@Ak-sky FYI the KMS code changes are all merged, so you should be good to now rebase with main branch here for review

@Ak-sky Ak-sky marked this pull request as ready for review May 31, 2023 06:38
@Ak-sky Ak-sky changed the title [DO NOT MERGE] feat: added fscloud profile feat: added fscloud profile May 31, 2023
ocofaigh
ocofaigh reviewed Jun 2, 2023
View reviewed changes
ocofaigh
ocofaigh reviewed Jun 2, 2023
View reviewed changes
ocofaigh
ocofaigh reviewed Jun 2, 2023
View reviewed changes
ocofaigh
ocofaigh reviewed Jun 2, 2023
View reviewed changes
ocofaigh
ocofaigh reviewed Jun 2, 2023
View reviewed changes
@Ak-sky Ak-sky reopened this Jun 2, 2023
@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 2, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 2, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 3, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 4, 2023

/run pipeline

ocofaigh
ocofaigh requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see latest comments

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 7, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 7, 2023

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 8, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 9, 2023

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 9, 2023

/run pipeline

ocofaigh
ocofaigh requested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove CBR references from examples/complete/README.md

@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 9, 2023

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 9, 2023

/run pipeline

ocofaigh
ocofaigh reviewed Jun 9, 2023
View reviewed changes
@Ak-sky
Copy link
Member Author

Ak-sky commented Jun 9, 2023

/run pipeline

@jojustin jojustin merged commit a8605a2 into main Jun 12, 2023
@jojustin jojustin deleted the es-fscloud branch June 12, 2023 15:03
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ak-sky @ocofaigh @terraform-ibm-modules-ops @jojustin