Skip to content

feat: added cbr support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2023
Merged

feat: added cbr support #28

merged 5 commits into from
May 26, 2023

Conversation

Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented May 24, 2023

Description

Added CBR support

Git-issue

https://github.ibm.com/GoldenEye/issues/issues/4833

Types of changes in this PR

Changes that affect the core Terraform module or submodules

  • Bug fix
  • New feature
  • Dependency update

Changes that don't affect the core Terraform module or submodules

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.

Your notes help the merger write the commit message for the PR that is published in the release notes for the module.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@Khuzaima05 Khuzaima05 self-assigned this May 24, 2023
Khuzaima-Shakeel added 2 commits May 25, 2023 11:50
@Khuzaima05 Khuzaima05 requested review from Ak-sky and ocofaigh and removed request for ocofaigh May 25, 2023 06:32
@Khuzaima05 Khuzaima05 closed this May 25, 2023
@Khuzaima05 Khuzaima05 reopened this May 25, 2023
@Khuzaima05 Khuzaima05 requested a review from ocofaigh May 25, 2023 07:11
@Khuzaima05 Khuzaima05 changed the title fix: added cbr support feat: added cbr support May 25, 2023
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the examples/complete/README.md file. Update the title to Complete example with BYOK encryption and CBR rules and also add a bullet point saying:

  • A context-based restriction (CBR) rule to only allow Event Streams to be accessible from within the VPC.

@Khuzaima05
Copy link
Member Author

@ocofaigh Getting this error CreateRuleWithContext failed Invalid API type 'crn:v1:bluemix:public:context-based-restrictions::::api-type:data-plane'. Service 'messagehub' does not support any API type. So should i remove the API type?
As there is no scope to API in event stream service named "messagehub" according to https://cloud.ibm.com/docs/account?topic=account-context-restrictions-whatis#cbr-adopters

@ocofaigh
Copy link
Contributor

@jojustin could you please advise on above? ^

@ocofaigh ocofaigh merged commit 69a468f into main May 26, 2023
@ocofaigh ocofaigh deleted the add_cbr branch May 26, 2023 21:08
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants