Skip to content

feat: exposed timeouts inputs in the enterprise DA + add upgrade test for enterprise DA #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Mar 5, 2025

Description

  • moved tests that run examples to other_test.go
  • created new upgrade test for enterprise DA
  • exposed timeouts inputs in the enterprise DA

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh requested review from Ak-sky and akocbek as code owners March 5, 2025 15:54
@ocofaigh
Copy link
Contributor Author

ocofaigh commented Mar 5, 2025

/run pipeline

@ocofaigh ocofaigh mentioned this pull request Mar 5, 2025
6 tasks
@ocofaigh
Copy link
Contributor Author

ocofaigh commented Mar 6, 2025

/run pipeline

@ocofaigh ocofaigh changed the title test: add upgrade test for enterprise DA feat: exposed timeouts inputs in the enterprise DA + add upgrade test for enterprise DA Mar 6, 2025
@ocofaigh
Copy link
Contributor Author

ocofaigh commented Mar 6, 2025

/run pipeline

@ocofaigh
Copy link
Contributor Author

ocofaigh commented Mar 7, 2025

There seems to be an issue which is causing instance provisioning more than 3 hours to occur. So although I updated the timeout, the upgrade test is using 3 hour timeout as that is what is in main branch. Skipping upgrade test to get tests to pass here

@ocofaigh
Copy link
Contributor Author

ocofaigh commented Mar 7, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 9ed9581 into main Mar 7, 2025
2 checks passed
@ocofaigh ocofaigh deleted the upgrade branch March 7, 2025 14:27
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants