fix: fireEvent.mouseEnter not forwarding relatedTarget properly #1429
+92
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed spread operator to explicit parameters in mouseEnter/mouseLeave - Fixed pointerEnter/pointerLeave and blur/focus for consistency - Added tests to verify relatedTarget is properly forwarded Fixes testing-library#1422
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f7ca7bc:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1422
Problem
fireEvent.mouseEnterwas not forwardingrelatedTargetproperly - it would bewindowinstead of the specified element.Solution
Changed spread operator to explicit parameters in
fire-event.js:(...args) =>→(node, init) =>This ensures
relatedTargetand other event properties are properly passed through.Changes
mouseEnter,mouseLeave,pointerEnter,pointerLeave,blur,focusTesting