Skip to content

Commit 8406802

Browse files
committed
Lint issues fixed (unused imports, unnecessary casts, simplified checking in JsonStreamerEntity)
1 parent c45f898 commit 8406802

14 files changed

+3
-24
lines changed

library/src/main/java/com/loopj/android/http/AsyncHttpRequest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.util.Log;
22-
2321
import org.apache.http.HttpResponse;
2422
import org.apache.http.client.HttpRequestRetryHandler;
2523
import org.apache.http.client.methods.HttpUriRequest;

library/src/main/java/com/loopj/android/http/AsyncHttpResponseHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import android.os.Handler;
2222
import android.os.Looper;
2323
import android.os.Message;
24-
import android.util.Log;
2524

2625
import org.apache.http.Header;
2726
import org.apache.http.HttpEntity;

library/src/main/java/com/loopj/android/http/BaseJsonHttpResponseHandler.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.util.Log;
22-
2321
import org.apache.http.Header;
2422
import org.apache.http.HttpStatus;
2523

library/src/main/java/com/loopj/android/http/BinaryHttpResponseHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
package com.loopj.android.http;
2020

2121
import android.os.Looper;
22-
import android.util.Log;
2322

2423
import org.apache.http.Header;
2524
import org.apache.http.HttpResponse;

library/src/main/java/com/loopj/android/http/DataAsyncHttpResponseHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
package com.loopj.android.http;
2020

2121
import android.os.Message;
22-
import android.util.Log;
2322

2423
import org.apache.http.HttpEntity;
2524
import org.apache.http.util.ByteArrayBuffer;

library/src/main/java/com/loopj/android/http/FileAsyncHttpResponseHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
package com.loopj.android.http;
2020

2121
import android.content.Context;
22-
import android.util.Log;
2322

2423
import org.apache.http.Header;
2524
import org.apache.http.HttpEntity;

library/src/main/java/com/loopj/android/http/JsonHttpResponseHandler.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.util.Log;
22-
2321
import org.apache.http.Header;
2422
import org.apache.http.HttpStatus;
2523
import org.json.JSONArray;
@@ -148,7 +146,7 @@ public void run() {
148146
public void run() {
149147
// In RFC5179 a null value is not a valid JSON
150148
if (!useRFC5179CompatibilityMode && jsonResponse == null) {
151-
onSuccess(statusCode, headers, (String) jsonResponse);
149+
onSuccess(statusCode, headers, (String) null);
152150
} else if (jsonResponse instanceof JSONObject) {
153151
onSuccess(statusCode, headers, (JSONObject) jsonResponse);
154152
} else if (jsonResponse instanceof JSONArray) {
@@ -199,7 +197,7 @@ public void run() {
199197
public void run() {
200198
// In RFC5179 a null value is not a valid JSON
201199
if (!useRFC5179CompatibilityMode && jsonResponse == null) {
202-
onFailure(statusCode, headers, (String) jsonResponse, throwable);
200+
onFailure(statusCode, headers, (String) null, throwable);
203201
} else if (jsonResponse instanceof JSONObject) {
204202
onFailure(statusCode, headers, throwable, (JSONObject) jsonResponse);
205203
} else if (jsonResponse instanceof JSONArray) {

library/src/main/java/com/loopj/android/http/JsonStreamerEntity.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
package com.loopj.android.http;
2020

2121
import android.text.TextUtils;
22-
import android.util.Log;
2322

2423
import org.apache.http.Header;
2524
import org.apache.http.HttpEntity;
@@ -374,7 +373,7 @@ static byte[] escape(String string) {
374373
break;
375374
default:
376375
// Reference: http://www.unicode.org/versions/Unicode5.1.0/
377-
if ((ch >= '\u0000' && ch <= '\u001F') || (ch >= '\u007F' && ch <= '\u009F') || (ch >= '\u2000' && ch <= '\u20FF')) {
376+
if ((ch <= '\u001F') || (ch >= '\u007F' && ch <= '\u009F') || (ch >= '\u2000' && ch <= '\u20FF')) {
378377
String intString = Integer.toHexString(ch);
379378
sb.append("\\u");
380379
int intLength = 4 - intString.length();

library/src/main/java/com/loopj/android/http/PersistentCookieStore.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import android.content.Context;
2222
import android.content.SharedPreferences;
2323
import android.text.TextUtils;
24-
import android.util.Log;
2524

2625
import org.apache.http.client.CookieStore;
2726
import org.apache.http.cookie.Cookie;

library/src/main/java/com/loopj/android/http/RangeFileAsyncHttpResponseHandler.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.util.Log;
22-
2321
import org.apache.http.Header;
2422
import org.apache.http.HttpEntity;
2523
import org.apache.http.HttpResponse;

library/src/main/java/com/loopj/android/http/RequestParams.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.util.Log;
22-
2321
import org.apache.http.HttpEntity;
2422
import org.apache.http.client.entity.UrlEncodedFormEntity;
2523
import org.apache.http.client.utils.URLEncodedUtils;

library/src/main/java/com/loopj/android/http/SaxAsyncHttpResponseHandler.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.util.Log;
22-
2321
import org.apache.http.Header;
2422
import org.apache.http.HttpEntity;
2523
import org.xml.sax.InputSource;

library/src/main/java/com/loopj/android/http/SimpleMultipartEntity.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
package com.loopj.android.http;
2525

2626
import android.text.TextUtils;
27-
import android.util.Log;
2827

2928
import org.apache.http.Header;
3029
import org.apache.http.HttpEntity;

library/src/main/java/com/loopj/android/http/TextHttpResponseHandler.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.util.Log;
22-
2321
import org.apache.http.Header;
2422

2523
import java.io.UnsupportedEncodingException;

0 commit comments

Comments
 (0)