Fix a bug where PHP 7.1 nullable types would generate a "Call to undefined method PhpParser\Node\NullableType::toString()" error.

Author: tomzx

src/PHPSemVerChecker/Comparator/Type.php

@@ -2,6 +2,8 @@
 
 namespace PHPSemVerChecker\Comparator;
 
+use PhpParser\Node\NullableType;
+
 class Type
 {
 	/**
@@ -17,11 +19,19 @@ public static function isSame($typeA, $typeB)
 	}
 
 	/**
-	 * @param \PhpParser\Node\Name|string|null $type
+	 * @param \PhpParser\Node\Name|\PhpParser\Node\NullableType|string|null $type
 	 * @return string|null
 	 */
 	public static function get($type)
 	{
-		return is_object($type) ? $type->toString() : $type;
+		if (! is_object($type)) {
+			return $type;
+		}
+
+		if ($type instanceof NullableType) {
+			return '?'.static::get($type->type);
+		}
+
+		return $type->toString();
 	}
 }

tests/PHPSemVerChecker/Comparator/TypeComparatorTest.php

@@ -0,0 +1,64 @@
+<?php
+
+namespace PHPSemVerChecker\Test\Comparator;
+
+use PhpParser\Node\Name;
+use PhpParser\Node\NullableType;
+use PHPSemVerChecker\Comparator\Type;
+use PHPSemVerChecker\Test\TestCase;
+
+class TypeComparatorTest extends TestCase
+{
+	/**
+	 * @dataProvider isSameProvider
+	 */
+	public function testIsSame($typeA, $typeB)
+	{
+		$this->assertTrue(Type::isSame($typeA, $typeB));
+	}
+
+	public function isSameProvider()
+	{
+		return [
+			[Name::concat(null, 'test'), Name::concat(null, 'test')],
+			['test', 'test'],
+			[null, null]
+		];
+	}
+
+	/**
+	 * @dataProvider isNotSameProvider
+	 */
+	public function testIsNotSame($typeA, $typeB)
+	{
+		$this->assertFalse(Type::isSame($typeA, $typeB));
+	}
+
+	public function isNotSameProvider()
+	{
+		return [
+			[Name::concat(null, 'test'), Name::concat(null, 'test1')],
+			['test', 'test1'],
+			[null, 'test']
+		];
+	}
+
+	/**
+	 * @dataProvider getProvider
+	 */
+	public function testGet($type, $expected)
+	{
+		$this->assertSame($expected, Type::get($type));
+	}
+
+	public function getProvider()
+	{
+		return [
+			[null, null],
+			['test', 'test'],
+			[Name::concat('namespaced', 'test'), 'namespaced\test'],
+			[new NullableType('test'), '?test'],
+			[new NullableType(Name::concat('namespaced', 'test')), '?namespaced\test'],
+		];
+	}
+}