Skip to content

Commit 931d81f

Browse files
emmetogemmetog
committed
Use case changed instead of rename in rule names
1 parent e50e738 commit 931d81f

12 files changed

+23
-23
lines changed

‎docs/Ruleset.md

+11-11
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ V070 | MINOR | Function parameter typing removed
1515
V071 | MINOR | Function parameter default added
1616
V072 | MAJOR | Function parameter default removed
1717
V073 | MINOR | Function parameter default value changed
18-
V160 | PATCH | Function renamed (case only)
18+
V160 | PATCH | Function name case changed
1919

2020
# Classes
2121

@@ -71,10 +71,10 @@ V096 | PATCH | Class private method parameter default removed
7171
V097 | MAJOR | Class public method parameter default value changed
7272
V098 | MAJOR | Class protected method parameter default value changed
7373
V099 | PATCH | Class private method parameter default value changed
74-
V150 | PATCH | Class public method renamed (case only)
75-
V156 | PATCH | Class protected method renamed (case only)
76-
V157 | PATCH | Class private method renamed (case only)
77-
V154 | PATCH | Class renamed (case only)
74+
V150 | PATCH | Class public method name case changed
75+
V156 | PATCH | Class protected method name case changed
76+
V157 | PATCH | Class private method name case changed
77+
V154 | PATCH | Class name case changed
7878
VXXX | MAJOR | *Final class public method parameter added*
7979
VXXX | MAJOR | *Final class protected method parameter added*
8080
VXXX | PATCH | *Final class private method parameter added*
@@ -114,8 +114,8 @@ V076 | MAJOR | Interface method parameter typing removed
114114
V077 | MINOR | Interface method parameter default added
115115
V078 | MAJOR | Interface method parameter default removed
116116
V079 | MAJOR | Interface method parameter default value changed
117-
V151 | PATCH | Interface method renamed (case only)
118-
V153 | PATCH | Interface renamed (case only)
117+
V151 | PATCH | Interface method name case changed
118+
V153 | PATCH | Interface name case changed
119119

120120
# Trait
121121

@@ -165,10 +165,10 @@ V114 | MAJOR | Trait private method parameter default removed
165165
V115 | MAJOR | Trait public method parameter default value changed
166166
V116 | MAJOR | Trait protected method parameter default value changed
167167
V117 | MAJOR | Trait private method parameter default value changed
168-
V152 | PATCH | Trait public method renamed (case only)
169-
V158 | PATCH | Trait protected method renamed (case only)
170-
V159 | PATCH | Trait private method renamed (case only)
171-
V155 | PATCH | Trait renamed (case only)
168+
V152 | PATCH | Trait public method name case changed
169+
V158 | PATCH | Trait protected method name case changed
170+
V159 | PATCH | Trait private method name case changed
171+
V155 | PATCH | Trait name case changed
172172

173173
# To classify
174174

‎src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public function analyze(Stmt $contextBefore, Stmt $contextAfter)
9292
// Leave non-strict comparison here
9393
if ($methodBefore != $methodAfter) {
9494

95-
// Detect method renamed case only.
95+
// Detect method case changed.
9696
// If we entered this section then the normalized names (lowercase) were equal.
9797
if ($methodBefore->name !== $methodAfter->name) {
9898
$report->add(

‎src/PHPSemVerChecker/Operation/ClassCaseChanged.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class ClassCaseChanged extends ClassOperationDelta {
1313
/**
1414
* @var string
1515
*/
16-
protected $reason = 'Class was renamed (case only).';
16+
protected $reason = 'Class name case was changed.';
1717
/**
1818
* @var string
1919
*/

‎src/PHPSemVerChecker/Operation/ClassMethodCaseChanged.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ class ClassMethodCaseChanged extends ClassMethodOperationDelta
1515
/**
1616
* @var string
1717
*/
18-
protected $reason = 'Method has been renamed (case only).';
18+
protected $reason = 'Method name case was changed.';
1919
}

‎src/PHPSemVerChecker/Operation/FunctionCaseChanged.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ class FunctionCaseChanged extends FunctionOperationDelta
1111
/**
1212
* @var string
1313
*/
14-
protected $reason = 'Function renamed (case only).';
14+
protected $reason = 'Function name case was changed.';
1515
}

‎src/PHPSemVerChecker/Operation/InterfaceCaseChanged.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ class InterfaceCaseChanged extends InterfaceOperationDelta {
1010
/**
1111
* @var string
1212
*/
13-
protected $reason = 'Interface was renamed (case only).';
13+
protected $reason = 'Interface name case was changed.';
1414
}

‎src/PHPSemVerChecker/Operation/TraitCaseChanged.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ class TraitCaseChanged extends TraitOperationDelta {
1313
/**
1414
* @var string
1515
*/
16-
protected $reason = 'Trait was renamed (case only).';
16+
protected $reason = 'Trait name case was changed.';
1717
}

‎tests/PHPSemVerChecker/Analyzer/ClassAnalyzerTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function testClassRemoved()
6363
$this->assertSame('tmp', $report[$context][$expectedLevel][0]->getTarget());
6464
}
6565

66-
public function testClassRenamedCaseOnly()
66+
public function testClassCaseChanged()
6767
{
6868
$before = new Registry();
6969
$after = new Registry();
@@ -78,7 +78,7 @@ public function testClassRenamedCaseOnly()
7878
$expectedLevel = Level::PATCH;
7979
Assert::assertDifference($report, $context, $expectedLevel);
8080
$this->assertSame('V154', $report[$context][$expectedLevel][0]->getCode());
81-
$this->assertSame('Class was renamed (case only).', $report[$context][$expectedLevel][0]->getReason());
81+
$this->assertSame('Class name case was changed.', $report[$context][$expectedLevel][0]->getReason());
8282
$this->assertSame('TestClass', $report[$context][$expectedLevel][0]->getTarget());
8383
}
8484
}

‎tests/PHPSemVerChecker/Analyzer/ClassMethodAnalyzerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ public function testClassMethodCaseChangeChanged($context, $visibility, $code)
744744

745745
$expectedLevel = LevelMapping::getLevelForCode($code);
746746
$this->assertSame($code, $report[$context][$expectedLevel][0]->getCode());
747-
$this->assertSame(sprintf('[%s] Method has been renamed (case only).', $visibility), $report[$context][$expectedLevel][0]->getReason());
747+
$this->assertSame(sprintf('[%s] Method name case was changed.', $visibility), $report[$context][$expectedLevel][0]->getReason());
748748
}
749749

750750
public function providerCaseChanged()

‎tests/PHPSemVerChecker/Analyzer/FunctionAnalyzerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ public function testFunctionCaseChanged()
414414
$expectedLevel = Level::PATCH;
415415
Assert::assertDifference($report, 'function', $expectedLevel);
416416
$this->assertSame('V160', $report['function'][$expectedLevel][0]->getCode());
417-
$this->assertSame('Function renamed (case only).', $report['function'][$expectedLevel][0]->getReason());
417+
$this->assertSame('Function name case was changed.', $report['function'][$expectedLevel][0]->getReason());
418418
$this->assertSame('someFunctionName', $report['function'][$expectedLevel][0]->getTarget());
419419
}
420420
}

‎tests/PHPSemVerChecker/Analyzer/InterfaceAnalyzerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,6 @@ public function testInterfaceCaseChanged()
8181
$expectedLevel = Level::PATCH;
8282
Assert::assertDifference($report, $context, $expectedLevel);
8383
$this->assertSame('V153', $report[$context][$expectedLevel][0]->getCode());
84-
$this->assertSame('Interface was renamed (case only).', $report[$context][$expectedLevel][0]->getReason());
84+
$this->assertSame('Interface name case was changed.', $report[$context][$expectedLevel][0]->getReason());
8585
}
8686
}

‎tests/PHPSemVerChecker/Analyzer/TraitAnalyzerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public function testTraitCaseChanged()
7878
$expectedLevel = Level::PATCH;
7979
Assert::assertDifference($report, $context, $expectedLevel);
8080
$this->assertSame('V155', $report[$context][$expectedLevel][0]->getCode());
81-
$this->assertSame('Trait was renamed (case only).', $report[$context][$expectedLevel][0]->getReason());
81+
$this->assertSame('Trait name case was changed.', $report[$context][$expectedLevel][0]->getReason());
8282
$this->assertSame('testtrait', $report[$context][$expectedLevel][0]->getTarget());
8383
}
8484
}

0 commit comments

Comments
 (0)