Load all repos from API (not just just first 30) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tial repo/member API loading.
caniszczyk
added a commit
that referenced
this pull request
Jul 24, 2012
Load all repos from API (not just just first 30)
Contributor
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a recursive getRepos() function that will load multiple pages of repo data from the Github API; the current implementation only loads 1 page and thus only shows 30 repos total. Also, a spinner has been added to the Statistics section during loading.
A running example of the changes in this pull request can be seen here:
http://codeforamerica.github.com/
(BTW, thanks for the great showcase app!)