Refactor Function unpackLibraryFromJarInternal in NativeUtils.java #1360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Added a Objects.requireNonNull check for the path parameter to ensure it's not null.
Used Files.createTempFile to create a temporary file instead of manually creating a directory and file. This ensures that the file is created securely and with a unique name.
Removed the unnecessary null check for temporaryDir, as it's now unnecessary with the use of Files.createTempFile.
Simplified the exception handling by catching IOException and NullPointerException separately, and removing the duplicate temp.delete() code.
Used method chaining to simplify the code and reduce nesting.