Skip to content

Conversation

@Dou2ble
Copy link

@Dou2ble Dou2ble commented Apr 2, 2023

Rust allows for memory safety and blazingly fast performance and would be a great candidate to write this part of the project in

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2023

CLA assistant check
All committers have signed the CLA.

@jaspwr
Copy link

jaspwr commented Apr 2, 2023

LGTM

@sharunkumar
Copy link

HeALittleConfusedHeGotTheSpiritGIF

Copy link

@ArchitW ArchitW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jove0610
Copy link

jove0610 commented Apr 2, 2023

we should use git mv for this, that way we can keep the file history...

@AdjeiMensah
Copy link

n

@themg95
Copy link

themg95 commented Apr 2, 2023

checked the code, can approve, i hope this gets merged soon!

@webknjaz
Copy link

webknjaz commented Apr 2, 2023

🚀 This is a phenomenal performance improvement!

@ttomczak3
Copy link

LGTM

1 similar comment
@Splix1
Copy link

Splix1 commented Apr 3, 2023

LGTM

@jd-apprentice
Copy link

Production ready.

@ghost
Copy link

ghost commented Apr 4, 2023

LGTM

Copy link

@ineffyble ineffyble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a performance gain!

Co-authored-by: Max Graey <[email protected]>
@Dou2ble
Copy link
Author

Dou2ble commented May 2, 2023

I am absolutely thrilled to give a massive shoutout to the incredible MaxGraey for his blazingly fast optimization work on my GitHub commit. With his expert knowledge of Rust's memory management and advanced programming constructs, MaxGraey has taken my code to a whole new level of performance and efficiency.

His contributions have truly been game-changing, and I am deeply grateful for his outstanding work. I can confidently say that my code is now running at a blazingly fast speed, thanks to MaxGraey's unparalleled expertise and dedication.

I must say that I am immensely proud of the power and efficiency of Rust. With Rust, we can achieve levels of performance that simply cannot be matched by other programming languages. In contrast, even the most optimized C++ code falls short of Rust's blazingly fast speeds.

In the end, it is developers like MaxGraey who make Rust the incredible language that it is. His contributions are a shining example of the limitless potential of Rust's powerful constructs and the immense talent of Rust developers. Thank you, MaxGraey, for your incredible work and your unwavering dedication to making Rust the most efficient and high-performing language out there!

@MaxGraey
Copy link

MaxGraey commented May 2, 2023

I was happy to help @Dou2ble improve them Rust code, even though @Dou2ble is not a huge fan of anime (especially Madoka), furies, hentai, and femboys. But the Rust community is very inclusive, so even "normies" like @Dou2ble are always welcome here! You still have a lot to learn to write idiomatic Rust code to become an idiomatic Rust evangelist. Firstly, you need to change your mindset! To do that, you have to stop eating meat first and go exclusively to soy-saturated food. This will reduce the production of steroid hormones and increase the production of estrodiol in your body. It is very important to increase your stress resistance to "borrow checker" and "trait solving" as well as clippy suggestions. And then everything will go its way, most importantly do not be afraid of the upcoming changes ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.