Skip to content

Missing converter: no-submodule-imports #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Oct 2, 2019 · 5 comments · Fixed by #223
Closed

Missing converter: no-submodule-imports #175

JoshuaKGoldberg opened this issue Oct 2, 2019 · 5 comments · Fixed by #223
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@JoshuaKGoldberg
Copy link
Member

💥 Missing Converter

  • tslint-to-eslint-config version: 1.2.0
  • typescript-eslint version: 2.3.2

TSLint Rule Name

no-submodule-imports

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments hacktoberfest labels Oct 2, 2019
@JoshuaKGoldberg
Copy link
Member Author

The issue here is that this package doesn't know how to convert the TSLint rule into the equivalent ESLint rule. Accepting PRs to add in a converter! 🙌

docs/Development.md has a root overview for how to get started. Within that, docs/Architecture.md#rule-converters talks about how these converters operate. Check the typescript-eslint roadmap to see suggestions on equivalent ESLint rules to convert to.

See #189 for an example of a simple rule converter that was recently added in.

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send in a PR to resolve this! ✨ label Oct 2, 2019
@KingDarBoja
Copy link
Collaborator

@JoshuaKGoldberg Can I take this one? Seems like it requires a plugin so I do wanna fix it just because why not 🍰

@JoshuaKGoldberg
Copy link
Member Author

Awesome, go ahead @KingDarBoja! 🍨

@ProdigyChrisLight
Copy link

I do not believe this is the correct conversion. TSLint's no-submodule-imports prevents submodules from other packages from being imported, where import/no-internal-modules will reject submodule imports from the same package.

@JoshuaKGoldberg
Copy link
Member Author

@ProdigyChrisLight interesting. Could you please file a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants