Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: unmeless/plotly.py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: unmeless/plotly.py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bug_1086
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 5, 2018

  1. Don't apply relayout operations to the view that originated the event 

    This fixes a zoom stutter that occurred on scroll zoom of 3d plots
    @jonmmease
    jonmmease committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    b353fb9 View commit details
    Browse the repository at this point in the history

  2. When computing overlapping properties to remove, don't leave empty ob… 

    …jects.

Before, while scroll zooming on scatter3d trace with multiple views we'd sometimes end up with a _props state of:

{'up': {'x': -0.4, 'y': -0.4, 'z': 0.8},
 'center': {'x': 0, 'y': 0, 'z': 0},
 'eye': {}}

When this happened, accessing a sub-property of eye would always return none, even though values existed in the _prop_defaults dict.

e.g.  fig.layout.scene.camera.eye.x would return None because the eye dict in _props was empty.

Now we just remove the eye property as well if all of it's own properties have been removed:

{'up': {'x': -0.4, 'y': -0.4, 'z': 0.8},
 'center': {'x': 0, 'y': 0, 'z': 0}}
    @jonmmease
    jonmmease committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    1386eb5 View commit details
    Browse the repository at this point in the history
Loading