Skip to content

favicon didn't respect **base** config #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
casyalex opened this issue Jun 21, 2022 · 1 comment
Closed
3 tasks done

favicon didn't respect **base** config #827

casyalex opened this issue Jun 21, 2022 · 1 comment
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@casyalex
Copy link
Contributor

casyalex commented Jun 21, 2022

Describe the bug

image

As screenshot shows, even set base config, favicon ignore this setting.
And when it seems working fine in dev env. But broke in deploy env.

Screen Shot 2022-06-21 at 15 52 40

Reproduction

Just start a random project with base config

Expected behavior

favicon url should respect base config

System Info

System:
    OS: macOS 12.4
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Memory: 145.51 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.17 - ~/.yarn/bin/yarn
    npm: 8.5.5 - ~/.config/yarn/global/node_modules/.bin/npm
  Browsers:
    Chrome: 102.0.5005.115
    Firefox: 89.0
    Safari: 15.5
  npmPackages:
    vitepress: ^1.0.0-alpha.2 => 1.0.0-alpha.2

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@casyalex casyalex added the bug: pending triage Maybe a bug, waiting for confirmation label Jun 21, 2022
@brc-dd
Copy link
Member

brc-dd commented Jun 21, 2022

We don't add favicon. You need to manually specify it. Refer #320 (comment). You're seeing that request (/favicon.ico) because that's what most browsers search for by default, but it can be overridden as shown in that comment.

@brc-dd brc-dd closed this as completed Jun 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

2 participants