Skip to content

[css-overflow] Should overflow-clip-margin take percentages? #5130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frivoal opened this issue May 29, 2020 · 3 comments
Closed

[css-overflow] Should overflow-clip-margin take percentages? #5130

frivoal opened this issue May 29, 2020 · 3 comments
Assignees
Labels
css-overflow-3 Current Work

Comments

@frivoal
Copy link
Collaborator

frivoal commented May 29, 2020

When we resolved in #4934 to introduce overflow-clip-margin, we did not discuss whether it should take a <length> or a <length-percentage>.

margin takes a <length-percentage>, but the new spec text defines overflow-clip-margin to take a <length>. We didn't discuss that point. On the one hand, analogy with margin would suggest <length-percentage>. On the other hand, overflow-clip-margin is mainly expected to be used to account for things like shadows and outlines, which do not take percentages. I'm leaning towards leaving it as a <length>, but not 100% sure, and we didn't discuss.

@frivoal frivoal added the css-overflow-3 Current Work label May 29, 2020
@frivoal frivoal self-assigned this May 29, 2020
@fantasai
Copy link
Collaborator

Let's just take a <length>. I don't think the use cases presented so far indicate the need for a percentage.

@tabatkins
Copy link
Member

Yup, I intentionally omitted percentage due to lack of use-case; as you say, the things that you mainly need to worry about clipping don't take percentages anyway. We can add it later if necessary.

@chrishtr
Copy link
Contributor

Closing per comments above as no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-overflow-3 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants