-
Notifications
You must be signed in to change notification settings - Fork 711
[css-view-transitions-1] Improve spec readability #8143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm going to take a pass on the spec and add loads of non-normative stuff to hopefully improve readability.
Couldn't they be said to be two different states? Two states can differ by many tree differences, style differences etc etc. |
Thanks! What is the state of a "DOM change"? I think you can say that a node tree is in a particular state, sure, though this is not something the DOM standard does. The DOM doesn't directly store all style information so I'm not sure that would be captured. |
Feels like the same root issue as #8144 |
Partially, but I think the wording is confusing as well. I don't think you can say that a change has state. |
Maybe we're reading the word 'state' differently. The intent here is that the document is in a particular state. Then a change is made, resulting in the document being in some different state. So, the document has undergone a "state change". The 'update' created the difference between those states by altering the tree/styles/etc. Feels like, here and #8144, we're looking for a word that communicates that the document model/style can change in a way that will result in a visual change, and that it was in some state/form/shape/structure before, and now it's in some different state/form/shape/structure. |
I understand the intent, but reading that sentence it doesn't convey that to me. The sentence suggests it's an API that allows DOM changes to do something. What can DOM changes do? They can animate between states. But that's not what this is. DOM changes cannot do anything. |
Ahh ok, I think I get it now. So instead of:
It could be:
|
Yeah, that looks good. Was struggling myself to come up with that wording. |
I'll look out for other stuff like that as I update it for readability. That section in particular will change a lot. |
Renaming this to capture a wider job of improving spec readability via:
|
I think this is complete. @annevk does it look better to you?
|
Friendly ping @annevk. Just checking if there is more work to be done here or we can close the issue. |
I think this can be closed, yeah. In particular given #8574. |
APIs*
But what I'm reading in the explainer is that it's a way to animate across a lot of node tree mutations at once.
cc @jakearchibald
The text was updated successfully, but these errors were encountered: