Skip to content

PresentationConnection.url should be optional? #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markafoltz opened this issue Jul 13, 2016 · 2 comments
Closed

PresentationConnection.url should be optional? #325

markafoltz opened this issue Jul 13, 2016 · 2 comments

Comments

@markafoltz
Copy link
Contributor

markafoltz commented Jul 13, 2016

The algorithm steps for creating a PresentationConnection set the url attribute after construction. It seems like we should make the attribute optional (like id) since it is not set in the constructor.

@markafoltz
Copy link
Contributor Author

Three algorithms that create PresentationConnection objects and set attributes after construction:

Alternatively, we could define a constructor that takes the url and id and modify the algorithms to use that; which seems better, since the API is not intended is to expose PresentationConnections without these properties set.

@markafoltz
Copy link
Contributor Author

Reviewing the spec, in all cases where the user agent instantiates a PresentationConnection, it sets both the URL and the ID before returning it to the caller. So it makes more sense to make both PresentationConnection.id and PresentationConnection.url mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant