Skip to content

setConnection in example 5.5 may put UI in an inconsistent state #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markafoltz opened this issue Sep 16, 2016 · 3 comments
Closed

setConnection in example 5.5 may put UI in an inconsistent state #339

markafoltz opened this issue Sep 16, 2016 · 3 comments
Labels
P3 v1

Comments

@markafoltz
Copy link
Contributor

setConnection() calls close() on an existing connection before adding an onconnect handler to the new connection. If the close event on the old connection fires after the connect event on the new connection, reset() will null out the new connection and disable the stop and disconnect buttons.
@markafoltz markafoltz added the P3 label Sep 16, 2016
@anssiko anssiko added the v1 label Sep 22, 2016
@tidoust
Copy link
Member

tidoust commented Sep 26, 2016

See discussion at TPAC

ACTION: @kenchris to review and fix the example in 5.5

@kenchris
Copy link
Contributor

#358

@markafoltz markafoltz mentioned this issue Nov 16, 2016
Merged
@markafoltz
Copy link
Contributor Author

Closing with the fixes in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 v1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anssiko @kenchris @tidoust @markafoltz