Skip to content

Sandboxing steps in start, reconnect, getAvailability are now useless #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tidoust opened this issue Dec 21, 2016 · 1 comment
Closed

Comments

@tidoust
Copy link
Member

tidoust commented Dec 21, 2016

Now that the PresentationRequest constructing steps also check sandboxing flags, I do not see any way to get into a situation where these flags need to be checked again in start, reconnect, or getAvailability.

When we discussed that, I thought sandboxing flag attributes could be changed on-the-fly. I was wrong, there is a warning in HTML5 which says: "These flags only take effect when the nested browsing context of the iframe is navigated. Removing them, or removing the entire sandbox attribute, has no effect on an already-loaded page":
http://www.w3.org/TR/html51/semantics-embedded-content.html#element-attrdef-iframe-sandbox

Now, these steps are essentially harmless, so we could leave them. They are just no-op in practice and could be dropped.

@markafoltz
Copy link
Contributor

Addressed by PR #399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants