Skip to content

Clarify self-navigation behavior in a presentation. #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2019

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Apr 4, 2019

This addresses feedback in Issue #455, to link navigation behavior to the HTML 5.1 navigation steps, and clarify how the receiving user agent should respond.

There's also a bunch of changes from attempting to run tidy-html5 which I'll clean up in another commit on this PR.


Preview | Diff

@markafoltz
Copy link
Contributor Author

PTAL @tidoust as you filed the original issue :-)

index.html Outdated
navigate</a>, it SHOULD NOT offer to open the resource in a new
<a>top-level browsing context</a>, but instead SHOULD abort the
navigation and possibly throw a <a>SecurityError</a> (consistent
with the <a>steps to navigate</a>).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not entirely "consistent" with the steps to navigate: the steps to navigate in HTML mandate the SecurityError be thrown when the exceptions enabled flag is set, whereas this makes it optional.

If the SecurityError exception cannot be mandated because it remains a challenge implementation-wise, I would suggest to drop "(consistent with the steps to navigate)".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing the exception isn't an implementation concern from my point of view. Rather I didn't want to get into the details here of when to throw a SecurityError and thus duplicate HTML. I rephrased this, let me know if that addresses your feedback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good!

@markafoltz
Copy link
Contributor Author

Thanks!

@markafoltz markafoltz merged commit fad8923 into gh-pages Apr 5, 2019
@markafoltz markafoltz deleted the issue-455-self-nav branch April 5, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants