-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Presentation API test #2432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presentation API test #2432
Conversation
…w.w3.org/TR/presentation-api/) tests is added. It contains two subfolders `controlling-ua` and `receiving-ua` for testing the API on controlling and receiving user agents. * initial `idlharness.html` is added for controlling and receiving user agents.
Critic review: https://critic.hoppipolla.co.uk/r/6051 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Reviewers for this pull request are: @w3c/presentation-api-reviewers. |
…rted by the `./lint` tool.
w3c-test:mirror |
Feel free to try the tests at |
* update idlharness.html with latest Presentation API interfaces from the ED
Thanks for kicking this off @louaybassbouss. Tests LGTM |
readonly attribute PresentationConnectionState state; | ||
void close(); | ||
void terminate(); | ||
attribute EventHandler onstatechange; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, seems the spec has some changes at w3c/presentation-api#227
Would you please update the IDL accordingly? Or shall we merge this as-is and address IDL update in following PRs?
Maybe you can add a comment in the test file to reflect the spec date for tracking.
LGTM with nit. |
As @louaybassbouss committed to keep the IDL up-to-date with the spec at w3c/presentation-api#266 (comment), I would like to land the initial pull request as-is. |
Dear all,
I am the Test Facilitator of the W3C Presentation API. This PR contains the initial folder structure and idlharness of the API for controlling and receiving user agents. I am happy to hear your feedback.
Thx,
Louay