Basic Use Case tests for the Presentation API #3062
Conversation
…s', 'starting a new presentation' and 'reconnect to a presentation' for the Presentation API
|
Critic review: https://critic.hoppipolla.co.uk/r/6547 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
w3c-test:mirror |
| @@ -0,0 +1,78 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
s/_manualTest/-manual/ in file name. See
|
@mariuswsl in the Presentation API F2F Meeting we discussed also the way how we create Presentation URLs that are compatible with Google Cast Receivers and other Receiving UAs. We need to replace in all tests |
Can we use relative presentation URL? |
|
@zqzhang agree relative URL is better if we want to run the tests from a local system and not from w3c-tests.org. @mariuswsl please consider this comment. |
| promise_test(function () { | ||
| return request.start() | ||
| .catch(function () { | ||
| assert_true(true); |
There was a problem hiding this comment.
Better check something here?
| .catch(function (err) { | ||
|
|
||
| test(function () { | ||
| assert_true(err.code == 20, 'The error code is equal to 20.'); |
There was a problem hiding this comment.
Better avoid magic number and use assert_equals.
You can also remove these 2 test wrapers; just make these 3 assertions in the promise test.
|
Merge this as-is so that you can regenerate a testing report and address the comment in following pull requests. |
Tests for the Use Cases 'monitor availability of presentation displays', 'starting a new presentation' and 'reconnect to a presentation' for the Presentation API
Tests for the Use Cases 'monitor availability of presentation displays', 'starting a new presentation' and 'reconnect to a presentation' for the Presentation API
Tests for the Use Cases 'monitor availability of presentation displays', 'starting a new presentation' and 'reconnect to a presentation' for the Presentation API.