-
Notifications
You must be signed in to change notification settings - Fork 3.3k
presentation-api idlharness update #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
presentation-api idlharness update #3238
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/6666 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
@zqzhang can you review and merge. I created a snapshot from the ED but I think there are minor changes comparing to the current idlharness. |
@louaybassbouss , please fix the lint error. |
@@ -36,15 +36,16 @@ | |||
|
|||
[Constructor(DOMString url)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just check the latest spec at Interface PresentationRequest, the constructor has been changed to [Constructor(DOMString url), Constructor(DOMString[] urls)]
Thanks @Honry for the review. @louaybassbouss please drop me a note when you address the comments above. |
LGTM 😄 |
* * update idlharness.html with latest Presentation API interfaces from the ED * * update idlharness for presentation API
update idlharness.html with latest Presentation API interfaces from the ED.