-
Notifications
You must be signed in to change notification settings - Fork 66
Distinguishing between data errors and user abort #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If they pass types that don't match the IDL, the bindings layer will generate a type error. If they are passing more data than the implementation allows (e.g. too many files, or files too large, or forbidden MIME types or file extensions), the implementation might generate a NotAllowedError. I don't see see other failures as being due to the user data. |
NotAllowedError seems good... I'll updated #113 |
Oh wait... NotAllowedError could be confused with "not triggered by user activation". Still unclear to me (with developer hat on 🤠) that my data was no good... even if it was valid at the WebIDL binding layer. |
The spec says:
We probably want a
DataError
error here, so a developer knows that it's not the user aborting, but something wrong with the data they are trying to pass.The text was updated successfully, but these errors were encountered: