Skip to content

[personality-insights] SDK overrides content-items' language. #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arypbatista opened this issue Mar 18, 2016 · 6 comments
Closed

[personality-insights] SDK overrides content-items' language. #220

arypbatista opened this issue Mar 18, 2016 · 6 comments
Assignees
Labels

Comments

@arypbatista
Copy link
Contributor

When using node-sdk's Personality Insights wrapper, and using contentItems as payload without specify a language, the wrapper will assume that the payload is in English.

This is a desired thing when sending text/plain payload, but if you do the same for application/json payload (content-items), then the service ignores each individual content-item language and tries to process all the content items with the wrapper's language choice.

@germanattanasio
Copy link
Contributor

I will assign this to nathan since I'm working on the java-skd now

@nfriedly
Copy link
Contributor

Oh, that's no good. Let me take a look.

@nfriedly
Copy link
Contributor

Actually, this kind of feels like a service bug. But I added a fix (and a couple of tests) to the Node SDK.

Do you know if this also affects the other SDKs?

@nfriedly
Copy link
Contributor

Oh, and it should be released as v1.3.1 once the CI loop finishes. Can you try it out and confirm that it resolves your issue @arypbatista ?

@arypbatista
Copy link
Contributor Author

Solved my issue @nfriedly . Thanks. I will raise an issue on the service too. Regards

@nfriedly
Copy link
Contributor

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants