Skip to content

fix: upgrade core version to 1.3.1 #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019
Merged

fix: upgrade core version to 1.3.1 #1005

merged 1 commit into from
Dec 9, 2019

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Dec 9, 2019

Upgrades the core version, which resolves #993

using the setting `noImplicitAny` will no longer cause build errors
Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #1005 into master will increase coverage by 22.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #1005       +/-   ##
==========================================
+ Coverage   77.77%    100%   +22.22%     
==========================================
  Files           1       1               
  Lines           9       9               
  Branches        2       2               
==========================================
+ Hits            7       9        +2     
+ Misses          2       0        -2
Impacted Files Coverage Δ
test/resources/auth_helper.js 100% <0%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac1431...63acdc7. Read the comment docs.

@dpopp07 dpopp07 merged commit 239cdab into master Dec 9, 2019
@dpopp07 dpopp07 deleted the fix/993 branch December 9, 2019 18:22
watson-github-bot pushed a commit that referenced this pull request Dec 9, 2019
## [5.2.1](v5.2.0...v5.2.1) (2019-12-09)

### Bug Fixes

* upgrade core version to 1.3.1 ([#1005](#1005)) ([239cdab](239cdab))
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Typescript compilation error due to missing Declaration file for test utils
4 participants