Skip to content

Merge CSS numeric factory functions into CSS typed OM #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foolip opened this issue Mar 28, 2025 · 2 comments
Open

Merge CSS numeric factory functions into CSS typed OM #2821

foolip opened this issue Mar 28, 2025 · 2 comments
Labels
feature definition Creating or defining new features or groups of features.

Comments

@foolip
Copy link
Collaborator

foolip commented Mar 28, 2025

#2000 added numeric factory functions (CSS.px() and friends) as a separate feature, but to my eye this is just part of CSS Typed OM and not useful in its own right. The functions all return a CSSUnitValue instance, but is there anything one can do with those objects without using the reset of CSS Typed OM?

A merge should wait until after #91 so that the old ID can be redirected.

cc @andruud @ddbeck @jamesnw

@jamesnw
Copy link
Collaborator

jamesnw commented Mar 28, 2025

This was always viewed as a junk drawer, with more context in #1847. The idea was that #971 would allow us to have composite features.

I don't think it's usable apart from Typed OM, but it was split into a separate feature since it does have a different support story. If #2820 collapses that support story, then I think it makes sense to merge.

@foolip
Copy link
Collaborator Author

foolip commented Apr 28, 2025

Alright, so my plan is to wait for #91 and then remove the feature, redirecting it to CSS typed OM. After #971 is fixed, we might retroactively make this a composite feature.

@ddbeck ddbeck added the feature definition Creating or defining new features or groups of features. label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

No branches or pull requests

3 participants