-
-
Notifications
You must be signed in to change notification settings - Fork 411
Making an unordered unreliable datachannel doesn't seem possible #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @echeese, could you provide a minimal reproducible example of this? I probably won't have time to work on it but if it is indeed a bug having such an example would be good |
@echeese Looking at #186 and webrtc-rs/data#5 I think you are just correct. No need to create a minimal repro. Someone who's interested in this could ressurect the PRs from @connorcarpenter |
Sorry for the lack of response, I was on vacation, but yes those PRs seem to match my findings |
No problem, if you wanna work on this it'd be great. I wouldn't expect it to get fixed unless someone with a desire for the use-case contributes a fix |
I have something: zduny@8a9138c References: But it would be nice to add a test checking if unreliable channel is created. |
What's the status on this? It seems like that PR was closed after submodule changes and was never actually merged. If needed, I can remake them, since it seems like nobody else actually cares about this use-case... strange considering the various rust game engines basing their netcode on this library without actually ... trying it. |
I do care; I don't care about reliability as I will be doing TCP inside WebRTC for my use case if I really need it. I have also created a set of patches (in my profile) which tries to disable all forms of reliability for the packets and all forms of congestion control and stats collection, if you're interested. It has made it lighter, too. Also a surprising observation: Tokio Mutexes and Semaphores are surprisingly too slow, so I switched some things to native threads, it made it work like 100x faster. Last time a performance bottleneck was fixed by just removing |
Creating a datachannel with
ordered = false
and (max_retransmits = 0
ormax_packet_lifetime = 0
) seems to fall back to making a reliable channel.The receiving other client has
maxPacketLifeTime: null
andmaxRetransmits: null
The text was updated successfully, but these errors were encountered: