Skip to content

request is deprecated #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Richienb opened this issue Apr 7, 2020 · 1 comment · Fixed by #445
Closed

request is deprecated #401

Richienb opened this issue Apr 7, 2020 · 1 comment · Fixed by #445
Labels
maybe-later

Comments

@Richienb
Copy link

Richienb commented Apr 7, 2020

The request package has been deprecated and should be replaced with another suitable package such as got.
@s0ph1e
Copy link
Member

s0ph1e commented Apr 10, 2020

Hi @Richienb

Thank you for suggestion 👍

I don't mind updating deprecated dependency.
It can be done only for next major version of this module. website-scraper relies on request's api and some options like request and plugins should be re-written.

relates to request/request#3142

@s0ph1e s0ph1e mentioned this issue Jul 5, 2020
Closed
@s0ph1e s0ph1e mentioned this issue May 8, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maybe-later
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace request with got website-scraper/node-website-scraper
2 participants
@s0ph1e @Richienb