Skip to content

Add pooch downloader to workaround RtD issue #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

znichollscr
Copy link
Contributor

@znichollscr znichollscr commented Nov 26, 2024

Issue is here: readthedocs/readthedocs.org#11763

This may bite in this repository soon, but was causing issues for me as a downstream user here: climate-resource/input4mips_validation#84

Fix from Mathias Hauser is here, that's what I've implemented here: readthedocs/readthedocs.org#11763 (comment)

@dcherian dcherian enabled auto-merge (squash) November 26, 2024 19:57
@dcherian dcherian merged commit 760b6b0 into xarray-contrib:main Mar 6, 2025
10 checks passed
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.25%. Comparing base (a9cebee) to head (ef33569).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
cf_xarray/utils.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   85.78%   86.25%   +0.46%     
==========================================
  Files          13       15       +2     
  Lines        2364     2953     +589     
  Branches      183      256      +73     
==========================================
+ Hits         2028     2547     +519     
- Misses        303      361      +58     
- Partials       33       45      +12     
Flag Coverage Δ
mypy 43.65% <0.00%> (+5.11%) ⬆️
unittests 93.36% <100.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants