add pooler suffix to DNS annotation of pooler LoadBalancer service #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
Jan-M,
hughcapet,
idanovinda,
jopadi and
sdudoladov
as code owners
|
Risk of breaking existing setups with change of DNS name for pooler LB. Feature added in 1.8. Felix will check. |
|
So far in order to get the DNS entry for the pooler LB one had to enable the normal LB as well because generateConnectionPoolerService calls generateServiceAnnotations function used also for the other services. This function does not check pooler LBs. So then you end up with two services using the same DNS and you don't know the route a request will take, right? Not sure, how many have really used the feature because of that? And as the normal LB has to be enabled for the DNS to be there, we can be sure that connections still work via the master|replica service. |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2180
Introduced two new functions:
generatePoolerServiceAnnotationsfor the DNS annotation used for LBs andgetCustomServiceAnnotationswhich is shared for all services. Because pooler unit tests need quite some refactoring, the annotations are tested in e2e suite.Functions
masterDNSNameandreplicaDNSNamenow take the cluster name as argument, to make them reusable for pooler DNS name resolving