rename failsafe_mode option in opconfig CRD #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
Jan-M,
hughcapet,
idanovinda,
jopadi and
sdudoladov
as code owners
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency in the naming of the global config option for Patroni's failsafe mode.
enable_patroni_failsafe_modein configmap andfailsafe_modein OpeartorConfiguration CRD. In #2297 we noticed that this option is still missing in the helm chart templates, but the difference in the naming would make it a bit harder to add it to the both configmap and CRD templates.Therefore, this PR will change the name in the CRD to
enable_patroni_failsafe_modeas well albeit being listed under thepatronikey. It also adds documentation which was still missing in the config reference. As the next release will the first version to support failsafe_mode by default, I do not think this renaming would break the setups of people out there.