kubernetes_use_configmap #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReSearchITEng
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
FxKu
reviewed
Mar 31, 2020
FxKu
reviewed
Mar 31, 2020
FxKu
reviewed
Mar 31, 2020
FxKu
reviewed
Mar 31, 2020
Co-Authored-By: Felix Kunde <[email protected]>
Co-Authored-By: Felix Kunde <[email protected]>
Co-Authored-By: Felix Kunde <[email protected]>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #855 bug, which causes missing selectors in master service, when they are actually required.
This way, this PR aligns operator with Patroni's DSC method: k8s with configMaps, by solving the bug in this "if condition":
postgres-operator/pkg/cluster/k8sres.go
Line 1339 in 07c5da3
Because the operator was mainly tested in k8s with the default "endpoints" option, this use case (configMaps) option was hidden till tests were done in OpenShift.
When the kubernetes_use_configmaps parameter is set to true, this PR will also export the required patroni environment variable with the same name: KUBERNETES_USE_CONFIGMAPS=true (as per patroni docs).