Skip to content

Commit 569259f

Browse files
author
Jeff Brateman
committed
Add @OverRide tags to missing locations
1 parent 5b6cefe commit 569259f

File tree

6 files changed

+23
-9
lines changed

6 files changed

+23
-9
lines changed

src/com/loopj/android/http/AsyncHttpClient.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@
6060
import org.apache.http.impl.client.DefaultHttpClient;
6161
import org.apache.http.impl.conn.tsccm.ThreadSafeClientConnManager;
6262
import org.apache.http.params.BasicHttpParams;
63-
import org.apache.http.params.HttpParams;
6463
import org.apache.http.params.HttpConnectionParams;
64+
import org.apache.http.params.HttpParams;
6565
import org.apache.http.params.HttpProtocolParams;
6666
import org.apache.http.protocol.BasicHttpContext;
6767
import org.apache.http.protocol.HttpContext;
@@ -135,6 +135,7 @@ public AsyncHttpClient() {
135135
httpContext = new SyncBasicHttpContext(new BasicHttpContext());
136136
httpClient = new DefaultHttpClient(cm, httpParams);
137137
httpClient.addRequestInterceptor(new HttpRequestInterceptor() {
138+
@Override
138139
public void process(HttpRequest request, HttpContext context) {
139140
if (!request.containsHeader(HEADER_ACCEPT_ENCODING)) {
140141
request.addHeader(HEADER_ACCEPT_ENCODING, ENCODING_GZIP);
@@ -146,6 +147,7 @@ public void process(HttpRequest request, HttpContext context) {
146147
});
147148

148149
httpClient.addResponseInterceptor(new HttpResponseInterceptor() {
150+
@Override
149151
public void process(HttpResponse response, HttpContext context) {
150152
final HttpEntity entity = response.getEntity();
151153
if (entity == null) {

src/com/loopj/android/http/AsyncHttpRequest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public AsyncHttpRequest(AbstractHttpClient client, HttpContext context, HttpUriR
4848
}
4949
}
5050

51+
@Override
5152
public void run() {
5253
try {
5354
if(responseHandler != null){

src/com/loopj/android/http/AsyncHttpResponseHandler.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,18 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.os.Handler;
22-
import android.os.Looper;
23-
import android.os.Message;
21+
import java.io.IOException;
22+
2423
import org.apache.http.HttpEntity;
2524
import org.apache.http.HttpResponse;
2625
import org.apache.http.StatusLine;
2726
import org.apache.http.client.HttpResponseException;
2827
import org.apache.http.entity.BufferedHttpEntity;
2928
import org.apache.http.util.EntityUtils;
3029

31-
import java.io.IOException;
30+
import android.os.Handler;
31+
import android.os.Looper;
32+
import android.os.Message;
3233

3334
/**
3435
* Used to intercept and handle the responses from requests made using
@@ -80,6 +81,7 @@ public AsyncHttpResponseHandler() {
8081
// Set up a handler to post events back to the correct thread if possible
8182
if(Looper.myLooper() != null) {
8283
handler = new Handler(){
84+
@Override
8385
public void handleMessage(Message msg){
8486
AsyncHttpResponseHandler.this.handleMessage(msg);
8587
}
@@ -122,6 +124,7 @@ public void onSuccess(int statusCode, String content) {
122124
* @param error the underlying cause of the failure
123125
* @deprecated use {@link #onFailure(Throwable, String)}
124126
*/
127+
@Deprecated
125128
public void onFailure(Throwable error) {}
126129

127130
/**

src/com/loopj/android/http/BinaryHttpResponseHandler.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818

1919
package com.loopj.android.http;
2020

21-
import android.os.Message;
21+
import java.io.IOException;
22+
2223
import org.apache.http.Header;
2324
import org.apache.http.HttpEntity;
2425
import org.apache.http.HttpResponse;
@@ -27,7 +28,7 @@
2728
import org.apache.http.entity.BufferedHttpEntity;
2829
import org.apache.http.util.EntityUtils;
2930

30-
import java.io.IOException;
31+
import android.os.Message;
3132

3233
/**
3334
* Used to intercept and handle the responses from requests made using
@@ -102,6 +103,7 @@ public void onSuccess(int statusCode, byte[] binaryData) {
102103
* @param binaryData the response body, if any
103104
* @deprecated
104105
*/
106+
@Deprecated
105107
public void onFailure(Throwable error, byte[] binaryData) {
106108
// By default, call the deprecated onFailure(Throwable) for compatibility
107109
onFailure(error);
@@ -116,6 +118,7 @@ protected void sendSuccessMessage(int statusCode, byte[] responseBody) {
116118
sendMessage(obtainMessage(SUCCESS_MESSAGE, new Object[]{statusCode, responseBody}));
117119
}
118120

121+
@Override
119122
protected void sendFailureMessage(Throwable e, byte[] responseBody) {
120123
sendMessage(obtainMessage(FAILURE_MESSAGE, new Object[]{e, responseBody}));
121124
}
@@ -133,6 +136,7 @@ protected void handleFailureMessage(Throwable e, byte[] responseBody) {
133136
}
134137

135138
// Methods which emulate android's Handler and Message methods
139+
@Override
136140
protected void handleMessage(Message msg) {
137141
Object[] response;
138142
switch(msg.what) {
@@ -151,6 +155,7 @@ protected void handleMessage(Message msg) {
151155
}
152156

153157
// Interface to AsyncHttpRequest
158+
@Override
154159
void sendResponseMessage(HttpResponse response) {
155160
StatusLine status = response.getStatusLine();
156161
Header[] contentTypeHeaders = response.getHeaders("Content-Type");

src/com/loopj/android/http/RetryHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public RetryHandler(int maxRetries) {
6565
this.maxRetries = maxRetries;
6666
}
6767

68+
@Override
6869
public boolean retryRequest(IOException exception, int executionCount, HttpContext context) {
6970
boolean retry = true;
7071

src/com/loopj/android/http/SyncHttpClient.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ public abstract class SyncHttpClient extends AsyncHttpClient {
1717
protected String result;
1818
protected AsyncHttpResponseHandler responseHandler = new AsyncHttpResponseHandler() {
1919

20-
void sendResponseMessage(org.apache.http.HttpResponse response) {
20+
@Override
21+
void sendResponseMessage(org.apache.http.HttpResponse response) {
2122
responseCode = response.getStatusLine().getStatusCode();
2223
super.sendResponseMessage(response);
2324
};
@@ -51,7 +52,8 @@ public int getResponseCode() {
5152
}
5253

5354
// Private stuff
54-
protected void sendRequest(DefaultHttpClient client,
55+
@Override
56+
protected void sendRequest(DefaultHttpClient client,
5557
HttpContext httpContext, HttpUriRequest uriRequest,
5658
String contentType, AsyncHttpResponseHandler responseHandler,
5759
Context context) {

0 commit comments

Comments
 (0)