fix: hardened the compatibility checks to ensure that we tests that l… #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oading of the module works
github-actions bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
## [1.4.4](v1.4.3...v1.4.4) (2025-06-04) ### Bug Fixes * fixed the workflow as a broken merge was committed ([2674d36](2674d36)) * hardened the compatibility checks to ensure that we tests that loading of the module works ([#34](#34)) ([77fd03c](77fd03c)) * updated the code to ensure compatibility with Python 3.9 ([01b749e](01b749e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the compatibility tests for the
zitadel-clientmodule. Previously, our tests only confirmed the module was installed. Now, they also import the module, which helps catch any errors that might occur when it's actually loaded and used.Related Issue
None
Motivation and Context
The old testing approach was incomplete; simply installing the module didn't guarantee it would work correctly when imported. This oversight could hide critical issues. By adding an import step to our tests, we can find these problems much earlier, leading to a more robust and reliable integration.
How Has This Been Tested?
These changes have been thoroughly tested using our Continuous Integration (CI) pipeline.
Documentation:
None
Checklist: