docs: Allow passing additional params to call_on_each_event.
#18007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`call_on_each_event` now supports additional params other than `event_type` and `narrow`; Ex: `all_public_streams` to fetch events of all public streams. Also add a bit of explanation of how this parameter works. Fixes zulip/python-zulip-api#647
timabbott
force-pushed
the
python-zulip-api#647
branch
from
63edc20 to
bdcbd53
Compare
|
This is great, merged after adding a bit more detail to the preexisting documentation. I also opened #18010, which I opened while reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call_on_each_eventnow supports additional params other thanevent_typeandnarrow; Ex:all_public_streamsto fetch eventsof all public streams.
Fixes zulip/python-zulip-api#647