msglist: Adding 🙂 emoji reaction fails

[chrisbobbe]

Reproduced on CZO just now:

1. Long-press a message
2. Tap the 🙂 emoji in the list of emoji at the top of the message action sheet
3. See error dialog (unexpected):

---

"zulip_version":"10.0-550-g2182f40bd5"

"zulip_feature_level":380

[gnprice]

Yeah, we should fix this.

Presumably this is due to the recent server change to make U+1F642 🙂 be called :slight_smile: instead of :smile::

• Remap smile emojis zulip#32712
• Remap ':smile' emoji and Update the settings UI  zulip#34177

The fix will probably involve updating this code:

  static final _popularCandidates = _generatePopularCandidates();

  static List<EmojiCandidate> _generatePopularCandidates() {
    // …
    return [
      // This list should match web:
      //   https://github.com/zulip/zulip/blob/83a121c7e/web/shared/src/typeahead.ts#L22-L29
      candidate('1f44d', '👍', ['+1', 'thumbs_up', 'like']),
      candidate('1f389', '🎉', ['tada']),
      candidate('1f642', '🙂', ['smile']),

The first step will be some refactoring to make that no longer static — it'll need to depend on zulipFeatureLevel.