Skip to content

Sync eng/common directory with azure-sdk-tools for PR 10615 #50019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10615 See eng/common workflow

@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 16:29
@azure-sdk azure-sdk requested a review from a team as a code owner May 13, 2025 16:29
@azure-sdk azure-sdk requested a review from chidozieononiwu May 13, 2025 16:29
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 13, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the eng/common directory with the latest updates from azure-sdk-tools for PR 10615.

  • Update the error message in the API View helper script to reference $HeadCommitish instead of $Commitish.
Comments suppressed due to low confidence (1)

eng/common/scripts/Helpers/ApiView-Helpers.ps1:200

  • Please verify that the variable $HeadCommitish is defined and consistently used throughout the script instead of $Commitish, ensuring that the commit identifier is correctly referenced.
LogError "Failed to get API View information for PR: $PrNumber in repo: $repoFullName with commitSHA: $HeadCommitish. Error: $_"

@chidozieononiwu chidozieononiwu merged commit 0929374 into main May 13, 2025
41 checks passed
@chidozieononiwu chidozieononiwu deleted the sync-eng/common-bugFix/APIViewHelpers-10615 branch May 13, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants