Skip to content

fix: username password flow #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: username password flow #536

merged 2 commits into from
Nov 28, 2024

Conversation

mohanjith
Copy link
Contributor

Adds the feature requested in #370

@mohanjith
Copy link
Contributor Author

@microsoft-github-policy-service agree

1 similar comment
@mohanjith
Copy link
Contributor Author

@microsoft-github-policy-service agree

@bgavrilMS bgavrilMS requested a review from 4gust November 22, 2024 11:59
@4gust
Copy link
Collaborator

4gust commented Nov 22, 2024

The changes look good overall; however, I noticed that there aren't any tests included for the new function. Could you please add some test cases to ensure the function works as expected and to help prevent regressions in the future?

Having tests will also make it easier to verify the changes and ensure compatibility with the existing codebase. Let me know if you need any guidance on setting up the tests or the testing framework.

bgavrilMS
bgavrilMS reviewed Nov 22, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mohanjith
Copy link
Contributor Author

@4gust I have added similar tests as in public client. Let me know if you would like to to write more tests.

Thank you!

@mohanjith mohanjith requested a review from bgavrilMS November 26, 2024 12:21
4gust
4gust approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@4gust 4gust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bgavrilMS bgavrilMS merged commit 06ce6ba into AzureAD:main Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@4gust 4gust 4gust approved these changes

@rayluo rayluo Awaiting requested review from rayluo rayluo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohanjith @4gust @bgavrilMS