-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix headers being mutated if passed to web.Response as a CIMultiDict #10672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #10672 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10672 +/- ##
==========================================
+ Coverage 98.10% 98.71% +0.61%
==========================================
Files 126 125 -1
Lines 37601 37445 -156
Branches 2132 2075 -57
==========================================
+ Hits 36887 36963 +76
+ Misses 545 335 -210
+ Partials 169 147 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 35c979b on top of patchback/backports/3.11/35c979be79dcc75ecbf7270ccc9fde264e5e2948/pr-10672 Backporting merged PR #10672 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 35c979b on top of patchback/backports/3.12/35c979be79dcc75ecbf7270ccc9fde264e5e2948/pr-10672 Backporting merged PR #10672 into master
🤖 @patchback |
…d to web.Response as a CIMultiDict (#10673) If `CIMultiDict` is passed in we need to make a copy to avoid mutating it. In some cases we used to copy these twice which was fixed in #10045 but for this case that was the only copy being made and the source of this regression. fixes #10670 (cherry picked from commit 35c979b)
…d to web.Response as a CIMultiDict (#10674)
What do these changes do?
If
CIMultiDict
is passed in we need to make a copy to avoid mutating it. In some cases we used to copy these twice which was fixed in #10045 but for this case that was the only copy being made and the source of this regression.fixes #10670