Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d5cb3e26efbcb6249e51a74e68346d7b02d0ee7c
Choose a base ref
...
head repository: angular/angular-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: be43ac307e9829a173a55cdb079acb79f6e4c19a
Choose a head ref
  • 17 commits
  • 39 files changed
  • 3 contributors

Commits on Jan 20, 2025

  1. Configuration menu
    Copy the full SHA
    4508725 View commit details
    Browse the repository at this point in the history
  2. build: delete npm archive accidentally committed

    This archive was accidentally commited and should be deleted.
    devversion authored and alan-agius4 committed Jan 20, 2025
    Configuration menu
    Copy the full SHA
    4595ca6 View commit details
    Browse the repository at this point in the history
  3. fix(@angular/ssr): prevent route matcher error when SSR routing is no…

    …t used
    
    Although route matchers are not supported with the SSR Routing API, they still function with the legacy `CommonEngine`. Therefore, no error should be issued in this case.
    
    Closes #29420
    
    (cherry picked from commit f3a9233)
    alan-agius4 committed Jan 20, 2025
    Configuration menu
    Copy the full SHA
    bcc5fab View commit details
    Browse the repository at this point in the history
  4. fix(@angular/ssr): unblock route extraction with `withEnabledBlocking…

    …InitialNavigation`
    
    This fix ensures that route extraction is not blocked when `withEnabledBlockingInitialNavigation` is used.
    
    Closes #29400
    
    (cherry picked from commit 4a1833d)
    alan-agius4 committed Jan 20, 2025
    Configuration menu
    Copy the full SHA
    59c7577 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2025

  1. fix(@angular/build): correct path for /@ng/components on Windows

    The `virtualProjectRoot` is normalized, but `sourcePath` is not, leading to mismatched path slashes and related issues.
    
    Closes #29424
    
    (cherry picked from commit abb186a)
    alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    ff8192a View commit details
    Browse the repository at this point in the history
  2. fix(@angular-devkit/schematics): ensure collections can be resolved v…

    …ia test runner in pnpm workspaces
    
    Currently when operating within a pnpm workspace and leveraging the
    schematic test runner, there are situations where e.g.
    `@schematics/angular` cannot be resolved. Consider this pnpm node
    modules structure:
    
    ```
    packages/
      pwa/
        node_modules/@schematics/angular --> .pnpm-store/@schematics/angular/...
        node_modules/@angular-devkit/schematics --> .pnpm-store/@angular-devkit/schematics/...
        index_spec.js // trying to call external schematic `@schematics/angular`
    ```
    
    This above setup will fail because `@schematics/angular` is attempted to
    be resolved from within the devkit schematics code, which doesn't have
    access, or a dependency on `@schematics/angular`. We can use the
    specified collection of the test runner to determine a good "resolution
    lookup site", similiar to how it happens with the real `ng update`
    command.
    devversion authored and alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    aa6f0d0 View commit details
    Browse the repository at this point in the history
  3. build: migrate @angular/pwa tests to rules_js

    This commit changes the execution of `@angular/pwa` tests to `rules_js`
    native `jasmine_test`.
    
    This requires setting it up in the pnpm workspace for first-party linked
    dependencies. Notably it turns out the peer dependency placeholder was
    incorrect, so we are fixing it here and nicely avoid a problem where
    pnpm would otherwise not find a local, or external suitable version.
    
    As we originally tried to work without the fix for the peer dependency
    range, there was supported added for extra substitutions. We are keeping
    that logic as it will likely be useful in the future.
    devversion authored and alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    cd775a7 View commit details
    Browse the repository at this point in the history
  4. build: migrate @angular-devkit/build-webpack tests to rules_js

    Migrates the `@angular-devkit/build-webpack` jasmine tests to
    `rules_js`. This requires wiring up in the pnpm workspace.
    
    Additionally `typescript` is added as it was missing as a "peer
    dependency" at runtime for `@ngtools/webpack`. This is expected, and
    we're already adding other peer deps before this change.
    devversion authored and alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    da08259 View commit details
    Browse the repository at this point in the history
  5. test: update saucelabs browsers versions

    Bump versions to latests
    
    (cherry picked from commit 197b770)
    alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    bce32c1 View commit details
    Browse the repository at this point in the history
  6. refactor: reduce dependencies on @angular-devkit/core

    By converting schemas from TypeScript `interfaces` to `types`, we can minimize the reliance on `json.JsonObject`. This approach avoids the error "Type 'Schema' does not satisfy the constraint 'JsonObject'" caused by the missing index signature for type 'string' in 'Schema'.
    
    (cherry picked from commit e7413d3)
    alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    5165265 View commit details
    Browse the repository at this point in the history
  7. fix(@angular/build): replace deprecation of i18n.baseHref with a wa…

    …rning
    
    In certain scenarios, users build applications with the same `baseHref` when using i18n, primarily for deploying localized applications across multiple domains. To address this, we are removing the deprecation of `i18n.baseHref` and will revisit potential options as part of #29111
    
    Instead of deprecating `i18n.baseHref`, we now issue a warning when it is used with SSR, as this may lead to undefined behavior.
    
    Closes #29396
    
    (cherry picked from commit 8535c11)
    alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    d50788c View commit details
    Browse the repository at this point in the history
  8. ci: replace platform linux with windows 11

    For some reason it seems all Linux tests are failing
    ```
    [15:25:13] I/testLogger - [chrome 132 Linux #1] PID: 17353
    [chrome 132 Linux #1] Specs: /tmp/angular-cli-e2e-HZAJ55/e2e-test/test-project/e2e/src/app.e2e-spec.ts
    [chrome 132 Linux #1]
    [chrome 132 Linux #1] [15:24:49] I/sauce - Using SauceLabs selenium server at https://ondemand.saucelabs.com:443/wd/hub
    [chrome 132 Linux #1] Jasmine started
    [chrome 132 Linux #1] [15:25:10] E/protractor - Could not find Angular on page http://localhost:2000/ : retries looking for angular exceeded
    ```
    https://github.com/angular/angular-cli/actions/runs/12890037755/job/35938861009
    
    (cherry picked from commit e01b4f6)
    alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    bd2ab46 View commit details
    Browse the repository at this point in the history
  9. fix(@angular/build): only issue invalid i18n config error for duplica…

    …te `subPaths` with inlined locales
    
    The i18n configuration validation was incorrectly flagging errors for identical `subPaths` when both locales were not inlined within the same build. This was due to the validation not properly accounting for the inlining of locales.
    
    This commit fixes this issue by ensuring that the validation only checks for duplicate `subPaths` when the locales are inlined.
    
    Closes #29398
    
    (cherry picked from commit 334ec0f)
    alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    c87a38f View commit details
    Browse the repository at this point in the history
  10. fix(@angular/build): include extracted routes in the manifest during …

    …prerendering
    
    This commit ensures that extracted routes are added to the manifest during prerendering. This guarantees a correct ng-server-context value for parameterized routes and provides a performance benefit by preventing route extraction from being repeated for every rendering worker.
    
    Closes #29426
    
    (cherry picked from commit 395562a)
    alan-agius4 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    14d2f7c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2025

  1. fix(@angular/ssr): properly manage catch-all routes with base href

    This fix ensures that catch-all routes (e.g., wildcard routes like `**`) are handled correctly when a base href is configured in an Angular SSR application.
    
    Closes #29397
    
    (cherry picked from commit 3546c6d)
    alan-agius4 committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    9bacf39 View commit details
    Browse the repository at this point in the history
  2. refactor(@angular/ssr): update getPathSegments to use `stripTrailin…

    …gSlash` instead of `filter(Boolean)`
    
    This change modifies the `getPathSegments` function to use `stripTrailingSlash`, providing a more consistent and reliable way to handle trailing slashes in paths. This update also resolves issues causing CI failures.
    
    (cherry picked from commit b0c2d19)
    alan-agius4 committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    c5d9038 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be43ac3 View commit details
    Browse the repository at this point in the history
Loading