-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(region-info): throw ValidationError
instead of untyped Errors
#33384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(region-info): throw ValidationError
instead of untyped Errors
#33384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnscopedValidationError
because this module doesn't operate on scopes
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
038607b
to
12b1a74
Compare
12b1a74
to
dfe9726
Compare
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Comments on closed issues and PRs are hard for our team to see. |
Issue
Relates to #32569
Description of changes
ValidationErrors
where apprporiateNote that files in the
build-tools
directory are excluded from the linter rules, since they are only used at build time.I moved the
before
function tobuild-tools
because it's not exported and only used at build time. Importing thecore
module to a build-time script doesn't work as it would add A LOT of additional files to the build-time hot path and that just completely blows the build script up 💥 (aside from it being totally unnecessary anyway).Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing tests. Exemptions granted as this is a refactor of existing code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license