Implement AsRef<[u8]> for UnparsedPublicKey
#790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 95.80% 92.91% -2.89%
==========================================
Files 61 71 +10
Lines 8143 9720 +1577
Branches 0 9720 +9720
==========================================
+ Hits 7801 9031 +1230
- Misses 342 421 +79
- Partials 0 268 +268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The errors from clippy look like they are unrelated to my code. They are probably due to a new clippy version? |
justsmth
force-pushed
the
unparsedpublickey-asref
branch
from
a998af2 to
7e56f8b
Compare
justsmth
approved these changes
Apr 28, 2025
skmcgrail
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #788
Description of changes:
Implement the
AsRef<[u8]>trait for the UnparsedPublicKey type to get access to the raw key.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.