update: change double negative variable and remove unused variable #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Andarist
reviewed
Apr 21, 2025
src/index.ts
Outdated
| @@ -37,8 +37,8 @@ const getOptionalInput = (name: string) => core.getInput(name) || undefined; | |||
|
|
|||
| let publishScript = core.getInput("publish"); | |||
| let hasChangesets = changesets.length !== 0; | |||
| const hasNonEmptyChangesets = changesets.some( | |||
There was a problem hiding this comment.
this wasn't broken - so let's not touch it
Andarist
reviewed
Apr 21, 2025
| @@ -318,7 +318,6 @@ export async function runVersion({ | |||
| }: VersionOptions): Promise<RunVersionResult> { | |||
| const octokit = setupOctokit(githubToken); | |||
|
|
|||
| let repo = `${github.context.repo.owner}/${github.context.repo.repo}`; | |||
There was a problem hiding this comment.
I'm OK with this change - but the rest should be reverted
There was a problem hiding this comment.
I've reverted rest of it f426667
This reverts commit 13cd17e.
NotAwar
added a commit
to Bane-NOR/changesets-action
that referenced
this pull request
May 5, 2025
* Remove unused variable (changesets#460) * unused variable * double negative var * Revert "double negative var" This reverts commit 13cd17e. * Introduce an option to use the GitHub API to commit changes, for GPG (changesets#391) * Create tags on GitHub using API To allow for signed tags to be created, rather than use the git CLI to push tags, manually push each tag using the GitHub API, which will sign the tag using the built-in GitHub GPG key. * Use ghcommit to push changes To allow for all commits to be signed, use the GitHub API to push changes. * Add changeset version * Allow tag publish to fail, assume it was manually published * Add to changeset * Update @s0/ghcommit * Update ghcommit to fix missing ref bug * Make using GitHub API Optional Change this to a minor version bump, with a new feature that allows for using the GitHub API to create tags and commits. * Use a strategy pattern for GitHub API vs CLI usage * refactor git interactions * fix mock thing * usechangesets pkg * switch to `commitMode` --------- Co-authored-by: Mateusz Burzyński <[email protected]> * Version Packages (changesets#463) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Changwan <[email protected]> Co-authored-by: Sam Lanning <[email protected]> Co-authored-by: Mateusz Burzyński <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update double negative variable for readability, and we don't use repo variable as we directly send
github.context.repo.repoto octokit