Skip to content

[6.0] Cherry-pick of #3270 - Handle null socket #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

paulmedynski
Copy link
Contributor

Cherry-pick of #3270.

@paulmedynski paulmedynski added this to the 6.0.2 milestone Apr 17, 2025
@paulmedynski paulmedynski requested a review from a team April 17, 2025 19:05
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.73%. Comparing base (cfb007d) to head (431a4bf).
Report is 8 commits behind head on release/6.0.

Files with missing lines Patch % Lines
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/6.0    #3283      +/-   ##
===============================================
- Coverage        72.78%   72.73%   -0.06%     
===============================================
  Files              285      285              
  Lines            59162    59165       +3     
===============================================
- Hits             43064    43036      -28     
- Misses           16098    16129      +31     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.60% <60.00%> (+0.05%) ⬆️
netfx 71.03% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit d66559a into release/6.0 Apr 19, 2025
251 checks passed
@paulmedynski paulmedynski deleted the dev/paul/release/6.0-null-socket branch April 19, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants