Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.22.9
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.22.10
Choose a head ref
  • 4 commits
  • 5 files changed
  • 4 contributors

Commits on Nov 19, 2024

  1. [release-branch.go1.22] time: accept "+01" in TestLoadFixed on OpenBSD

    This stops the test from failing with a known failure mode, and
    creates time to look into what the next steps should be, if any.
    
    For #69840.
    Fixes #70238.
    
    Change-Id: I060903d256ed65c5dfcd70ae76eb361cab63186f
    Reviewed-on: https://go-review.googlesource.com/c/go/+/625197
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Eric Grosse <[email protected]>
    (cherry picked from commit bea9b91)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/627416
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Commit-Queue: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    dmitshur authored and gopherbot committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3355db9 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. [release-branch.go1.22] syscall: mark SyscallN as noescape

    syscall.SyscallN is implemented by runtime.syscall_syscalln, which makes
    sure that the variadic argument doesn't escape.
    
    There is no need to worry about the lifetime of the elements of the
    variadic argument, as the compiler will keep them live until the
    function returns.
    
    For #70197
    Fixes #70201
    
    Change-Id: I12991f0be12062eea68f2b103fa0a794c1b527eb
    Reviewed-on: https://go-review.googlesource.com/c/go/+/625297
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Alex Brainman <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit 7fff741)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/630215
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Quim Muntal <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    qmuntal authored and gopherbot committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6f05fa7 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. [release-branch.go1.22] runtime: reserve 4kB for system stack on wind…

    …ows-386
    
    The failures in #70288 are consistent with and strongly imply
    stack corruption during fault handling, and debug prints show
    that the Go code run during fault handling is running about
    300 bytes above the bottom of the goroutine stack.
    That should be okay, but that implies the DLL code that called
    Go's handler was running near the bottom of the stack too,
    and maybe it called other deeper things before or after the
    Go handler and smashed the stack that way.
    
    stackSystem is already 4096 bytes on amd64;
    making it match that on 386 makes the flaky failures go away.
    It's a little unsatisfying not to be able to say exactly what is
    overflowing the stack, but the circumstantial evidence is
    very strong that it's Windows.
    
    For #70288.
    Fixes #70474.
    
    Change-Id: Ife89385873d5e5062a71629dbfee40825edefa49
    Reviewed-on: https://go-review.googlesource.com/c/go/+/627375
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Russ Cox <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit 7eeb0a1)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/632197
    Reviewed-by: Cherry Mui <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Veronica Silina <[email protected]>
    rsc authored and gopherbot committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    6d7a95a View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. [release-branch.go1.22] go1.22.10

    Change-Id: I5e9be77389bcb215c114013c169841cfbcaa9550
    Reviewed-on: https://go-review.googlesource.com/c/go/+/633235
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Veronica Silina <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    gopherbot committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    8f3f22e View commit details
    Browse the repository at this point in the history
Loading