ringhash: normalize uppercase in requestHashHeader from service config #8243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8243 +/- ##
==========================================
+ Coverage 82.09% 82.12% +0.02%
==========================================
Files 412 412
Lines 40491 40492 +1
==========================================
+ Hits 33242 33253 +11
+ Misses 5876 5874 -2
+ Partials 1373 1365 -8
🚀 New features to boost your workflow:
|
yousukseung
force-pushed
the
ring-hash-md-lowercase
branch
from
f9007f4 to
44d5dea
Compare
With gRFC A76 (grpc#8159), when requestHashHeader is specified from the service config it fails the validation since MD keys with uppercase letters are normalized to lowercase. We should normalize the parsed value before validation.
yousukseung
force-pushed
the
ring-hash-md-lowercase
branch
from
44d5dea to
3b8052a
Compare
arjan-bal
approved these changes
Apr 14, 2025
arjan-bal
added
the
Area: Resolvers/Balancers
atollena
approved these changes
Apr 14, 2025
|
@yousukseung the test failure may be related to the changes in the PR, can you PTAL: https://github.com/grpc/grpc-go/actions/runs/14410175562/job/40416016501?pr=8243 |
I was able to reproduce the failure on the master branch, I opened #8247 to track this. |
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Apr 16, 2025
purnesh42H
added a commit
that referenced
this pull request
Apr 16, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gRFC A76 (#8159), when requestHashHeader is specified from the service config it fails the validation since MD keys with uppercase letters are normalized to lowercase. We should normalize the parsed value before validation.
RELEASE NOTES: N/A