Switch back to Hoek.clone from lodash.deepClone.

[Invader444]

Fix lint-md script in package.json to work on Windows.

[Invader444]

With this patch, you should have no issues with a set of Windows builds on Travis. Can we do that too as part of this PR? :)

[geek]

@Invader444 Awesome! Yes please update this PR with

os:
  - windows
  - linux
  - osx

for travis

[Invader444]

Well.. that is bizarre! I have no such errors in my test output! Ill look into this more tomorrow :/

[Marsup]

Classic \n -> \r\n on windows 🤦‍♂️

[Invader444]

Ohhh. Git needs to checkout without auto crlf?

[Marsup]

We rather need to test with regexps matching both cases.

[Invader444]

lol!

lib/reporters/console.js missing coverage on line(s): 409-411, 413, 416-418, 420
Code coverage below threshold: 99.65 < 100

::sigh::

I'm not sure why I don't see these Windows errors, although, for one thing I am getting unix-style newlines in my output... perhaps because of nvm?

[Invader444]

@geek, does that coverage report make sense to you? It looks like the line numbers may be inaccurate... :(

[geek]

@Invader444 that missing coverage appears to be related to the supports color tty detection. We are using an outdated version and may just need to update to the latest.

[Invader444]

With latest commit:

C:\Users\Jon\workspace\git\Doomtrooper\lab>npm run test
npm WARN npm npm does not support Node.js v10.0.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN npm npm does not support Node.js v10.0.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/

> [email protected] test C:\Users\Jon\workspace\git\Doomtrooper\lab
> node ./bin/_lab -fL -t 100 -m 3000



  ..................................................
  ..................................................
  ..................................................
  ..................

  .

1 tests complete
Test duration: 1 ms
No global variable leaks detected

................................
  ..................................................
  ..................................................
  ................................................

348 tests complete
Test duration: 42994 ms
No global variable leaks detected
Coverage: 100.00%
Linting results: No issues


> [email protected] posttest C:\Users\Jon\workspace\git\Doomtrooper\lab
> npm run lint-md

npm WARN npm npm does not support Node.js v10.0.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN npm npm does not support Node.js v10.0.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/

> [email protected] lint-md C:\Users\Jon\workspace\git\Doomtrooper\lab
> eslint --config hapi --rule "strict: 0, eol-last: 0" --plugin markdown --ext md --parser-options "ecmaVersion: 9" .


C:\Users\Jon\workspace\git\Doomtrooper\lab>

[Invader444]

lib/reporters/console.js missing coverage on line(s): 409-411, 413, 416-418, 420
Code coverage below threshold: 99.65 < 100

@geek any other ideas? :(

[geek]

@Invader444 thoughts on removing windows from travis until we can sort out the build issue? If we revert the travis change then I'll go ahead and merge/release and we can come back to build issues.

[Invader444]

Eureka! A few more tweaks were needed, but it seems to be working now :)

process.stdout.isTTY is false for windows travis builds... they've done this before too: chalk/supports-color#63

Ideally this would be fixed in supports-color upstream, but looks like they won't do that as the last time they tried in the above PR it broke backwards compatibility for some of their package's consumers.

[geek]

@Invader444 thanks a lot for your help. This is now published as 18.0.1

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.