Skip to content

KTOR-6036 Add deprecations for old IO #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

KTOR-6036 Add deprecations for old IO #3659

merged 1 commit into from
Jul 31, 2023

Conversation

e5l
Copy link
Member

@e5l e5l commented Jun 21, 2023

No description provided.

@e5l e5l changed the base branch from main to 3.0.0-eap June 21, 2023 12:51
@e5l e5l self-assigned this Jun 21, 2023
@e5l e5l force-pushed the 3.0.0-eap branch 2 times, most recently from 615ee7d to 3eb61ab Compare July 3, 2023 07:43
@e5l e5l force-pushed the 3.0.0-eap branch 2 times, most recently from 94eb9d8 to 94a0c5d Compare July 7, 2023 08:01
@e5l e5l changed the base branch from 3.0.0-eap to main July 7, 2023 08:02
@e5l e5l requested a review from rsinukov July 26, 2023 11:12
@e5l e5l force-pushed the e5l/io-deprecations branch from 3d7d2f7 to 6dc06d1 Compare July 26, 2023 11:20
@e5l e5l marked this pull request as ready for review July 26, 2023 11:20
rsinukov
rsinukov suggested changes Jul 31, 2023
View reviewed changes
Copy link

@rsinukov rsinukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid suppressing all deprecation in the file?

@e5l e5l force-pushed the e5l/io-deprecations branch from 6dc06d1 to af01010 Compare July 31, 2023 12:15
@e5l
Copy link
Member Author

e5l commented Jul 31, 2023

Fixed, @rsinukov please check

@e5l e5l requested a review from rsinukov July 31, 2023 12:15
@e5l e5l force-pushed the e5l/io-deprecations branch from af01010 to 05d15af Compare July 31, 2023 14:06
rsinukov
rsinukov approved these changes Jul 31, 2023
View reviewed changes
Copy link

@rsinukov rsinukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the codestyle

@e5l e5l force-pushed the e5l/io-deprecations branch from 05d15af to ddc2be8 Compare July 31, 2023 16:31
@e5l e5l force-pushed the e5l/io-deprecations branch from ddc2be8 to a5e0e97 Compare July 31, 2023 17:10
@e5l e5l merged commit 273fc7d into main Jul 31, 2023
@e5l e5l deleted the e5l/io-deprecations branch July 31, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsinukov rsinukov rsinukov approved these changes

Assignees

@e5l e5l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e5l @rsinukov